Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review - Jishva Shah #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Code Review - Jishva Shah #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,10 @@ Bootstrap
## License

This project is licensed under the MIT License. See the LICENSE file for details.

## Code Review - Jishva Shah
You really did a good job! The website has a smooth flow and the code structure is clear and easy to understand.
Here are some small things that i'd like to suggest:
1. The alerts displayed on screen can be implemented in such way that they disappear after some time, so that user don't have to click on 'x' everytime and alerts won't fill up the screen.
2. Also the alignment for creating flashcards can be better. Displaying them and generating them can be in two different pages.
Overall, really liked your website!