Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Review - Jishva Shah #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Code Review - Jishva Shah #1

wants to merge 1 commit into from

Conversation

JishvaShah
Copy link

@JishvaShah JishvaShah commented Dec 7, 2023 •
edited
Loading

Code Review - Jishva Shah

You really did a good job! The website has a smooth flow and the code structure is clear and easy to understand.
Here are some small things that i'd like to suggest:

  1. The alerts displayed on screen can be implemented in such way that they disappear after some time, so that user don't have to click on 'x' everytime and alerts won't fill up the screen.
  2. Also the alignment for creating flashcards can be better. Displaying them and generating them can be in two different pages.
    Overall, really liked your website!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JishvaShah