Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Fix configure() return type #49648

Closed
wants to merge 2 commits into from
Closed

[11.x] Fix configure() return type #49648

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adfbc92
fix doc type
TomasVotruba Jan 11, 2024
e2d139a
use native type
TomasVotruba Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Illuminate/Foundation/Application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use Illuminate\Events\EventServiceProvider;
use Illuminate\Filesystem\Filesystem;
use Illuminate\Foundation\Bootstrap\LoadEnvironmentVariables;
use Illuminate\Foundation\Configuration\ApplicationBuilder;
use Illuminate\Foundation\Events\LocaleUpdated;
use Illuminate\Http\Request;
use Illuminate\Log\LogServiceProvider;
Expand Down Expand Up @@ -221,9 +222,8 @@ public function __construct($basePath = null)
* Begin configuring a new Laravel application instance.
*
* @param string|null $baseDirectory
* @return \Illuminate\Foundation\ApplicationBuilder
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class does not exist, Configuration was missing

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type-ezgif com-cut

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add return type into doc

*/
public static function configure(string $baseDirectory = null)
public static function configure(string $baseDirectory = null): ApplicationBuilder
{
$baseDirectory = match (true) {
is_string($baseDirectory) => $baseDirectory,
Expand Down