[11.x] Fix configure() return type #49648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
commented
Jan 11, 2024
| @@ -221,9 +222,8 @@ public function __construct($basePath = null) | |||
| * Begin configuring a new Laravel application instance. | |||
| * | |||
| * @param string|null $baseDirectory | |||
| * @return \Illuminate\Foundation\ApplicationBuilder | |||
There was a problem hiding this comment.
This class does not exist, Configuration was missing
There was a problem hiding this comment.
Add return type into doc
driesvints
changed the title
|
Thanks @TomasVotruba. Instead I just fixed the docblock itself: af5ba26 |
|
Thanks 👍 Just curious, why not change the type declaration? |
|
We don’t really add native return types to internal code. |
|
Why is that? |
|
Just because that’s how we’ve always been doing it |
|
I see. Would you be open to use native return types? |
|
Not right now sorry. We’re going to leave things be 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I've upgrade my personal and Rector website to Laravel 11 to try out new configuration API:
All is good!
One glitch is that the IDE autocomplete didn't work for me. I though there is some IDE cache, but in the end it was the return type issue.
This should fix it 👍
Using native return type seems a good idea, as we're using PHP 8.2 as min, and the incorrect return native type declaration would show this bug even in the PR adding this feature.
Let me know what you think and what should I improve 🙏