Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation build script #158

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Update documentation build script #158

merged 4 commits into from
Sep 21, 2023

Conversation

odow
Copy link
Collaborator

@odow odow commented Sep 20, 2023

Replaces #157

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #158 (a3dc74a) into master (f6aca5f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #158   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files          39       39           
  Lines        4174     4174           
=======================================
  Hits         3840     3840           
  Misses        334      334           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6aca5f...a3dc74a. Read the comment docs.

@odow
Copy link
Collaborator Author

odow commented Sep 20, 2023

So the push-preview didn't help. My guess is that it's because the symlink existed before GitHub actions, so they must have marked it as potentially malicious: https://github.com/orgs/community/discussions/9104#discussioncomment-5218741

I've added a new CI job which cleans up left-over preview builds, and it has the side-effect that it results in a new commit from GitHub actions that touches every file.

@odow
Copy link
Collaborator Author

odow commented Sep 20, 2023

So perhaps we could merge this and see what happens?

docs/make.jl Outdated Show resolved Hide resolved
docs/make.jl Outdated Show resolved Hide resolved
@odow odow merged commit 2a2618d into master Sep 21, 2023
21 checks passed
@odow odow deleted the od/docs branch September 21, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant