Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation build script #157

Closed
wants to merge 1 commit into from
Closed

Conversation

odow
Copy link
Collaborator

@odow odow commented Sep 20, 2023

@tasseff could you add me as a collaborator so I have permission to push to lanl-ansi? That'll let our push_preview deploy and we can see if it still errors.

@odow
Copy link
Collaborator Author

odow commented Sep 20, 2023

The symlink was last updated 4 years ago: https://github.com/lanl-ansi/WaterModels.jl/blob/gh-pages/latest

So I wonder if it's sufficient to just do a force push and update it. The JuMP docs don't have this problem.

cc @mortenpi have you ever seen: https://github.com/lanl-ansi/WaterModels.jl/runs/16867659695

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #157 (74947fb) into master (f6aca5f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files          39       39           
  Lines        4174     4174           
=======================================
  Hits         3840     3840           
  Misses        334      334           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6aca5f...74947fb. Read the comment docs.

@ccoffrin
Copy link
Member

@odow I added the push role.

@mortenpi
Copy link

cc @mortenpi have you ever seen: https://github.com/lanl-ansi/WaterModels.jl/runs/16867659695

Nope. And it looks weird.. why would it suddenly start failing. Maybe just re-run the pages build workflow?

@odow
Copy link
Collaborator Author

odow commented Sep 20, 2023

Closing if favor of #158

@odow odow closed this Sep 20, 2023
@odow odow deleted the od/docs branch September 20, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants