Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] More verbs/nouns fixes in disambiguation.xml #11052

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

marcoagpinto
Copy link
Member

@marcoagpinto marcoagpinto commented Nov 21, 2024

More fixes.

Summary by CodeRabbit

  • New Features
    • Updated Portuguese grammar rule to include the token "acerca" for improved verb removal context.
  • Bug Fixes
    • Renamed rule for clarity and accuracy in grammatical usage.

Copy link
Contributor

coderabbitai bot commented Nov 21, 2024

Walkthrough

The changes in this pull request involve the modification of the disambiguation.xml file for Portuguese grammar rules in LanguageTool. Specifically, the rule previously named PELA_COMO_SOBRE_NADA_VERBS_RARE has been renamed to PELA_COMO_SOBRE_NADA_ACERCA_VERBS_RARE. This change incorporates the token "acerca" into the rule's pattern, which already included "pela", "como", "sobre", and "nada". The rule's function remains unchanged, focusing on the removal of certain verbs when preceded by these tokens.

Changes

File Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml Renamed rule from PELA_COMO_SOBRE_NADA_VERBS_RARE to PELA_COMO_SOBRE_NADA_ACERCA_VERBS_RARE to include the token "acerca".

Possibly related PRs

Suggested reviewers

  • jaumeortola
  • p-goulart
  • susanaboatto

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 8573910 and 511e2fe.

📒 Files selected for processing (1)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (2 hunks)
🔇 Additional comments (3)
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (3)

3816-3818: LGTM! Rule name updated to reflect the addition of 'acerca' token.

The rule ID and name change from PELA_COMO_SOBRE_NADA_VERBS_RARE to PELA_COMO_SOBRE_NADA_ACERCA_VERBS_RARE accurately reflects the addition of the "acerca" token to the pattern.


3823-3823: LGTM! Pattern updated to include 'acerca' token.

The token pattern was correctly updated to include "acerca" in the regexp alternatives list: pel[ao]s?|como|sobre|nada|acerca


3841-3841: LGTM! Documentation updated with new example.

The examples section was appropriately updated to include a new example demonstrating the "acerca" usage: "Na audiência, nada foi comprovado acerca da alegação do convite às testemunhas."


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant