[pt] More verbs/nouns fixes in disambiguation.xml

[marcoagpinto]

Even more fixes 😛 😛

Summary by CodeRabbit

• New Features

  • Updated Portuguese grammar rule for improved accuracy in verb identification.
  • Enhanced rule description to include "verbo elar," broadening its application scope.

• Bug Fixes

  • Refined regular expression patterns to better capture specific verb forms.

• Chores

  • Removed outdated comments to streamline the rule's documentation.

[coderabbitai]

Walkthrough

This pull request modifies the disambiguation.xml file for Portuguese grammar rules in LanguageTool. It primarily involves renaming a rule from PELA_COMO_SOBRE_NADA_ACERCA_VERBS_RARE to PELA_COMO_SOBRE_NADA_ACERCA_ELAR_VERBS_RARE, reflecting an adjustment in its description to include "verbo elar." The rule's pattern has been updated to enhance specificity, and comments providing examples of the rule's application have been removed. The overall structure of the XML remains unchanged, maintaining the logic of the rule.

Changes

File	Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml	Renamed rule from PELA_COMO_SOBRE_NADA_ACERCA_VERBS_RARE to PELA_COMO_SOBRE_NADA_ACERCA_ELAR_VERBS_RARE and updated the pattern to include el[ae]s?. Removed comments that provided examples.

Possibly related issues

• [pt] Disambiguator verbs/nouns issues — 2024-10-19 #10954: The changes in this PR may help address issues related to verb disambiguation, as the renaming and pattern updates could improve the handling of false positives in verb identification.

Possibly related PRs

• [pt] More nouns/verbs improved in disambiguation.xml #11009: Modifies the disambiguation.xml file by renaming the rule PELA_COMO to PELA_COMO_VERBS, which aligns with the focus on renaming rules for verb identification.
• [pt] Added more verbs/nouns fixes in disambiguation.xml #11014: Updates the rule for handling the verb "dá" and its context, relevant to the changes in verb-related rules in this PR.
• [pt] Tons of verbs/nouns fixes in disambiguation.xml #11028: Introduces a new rule VERB_O_A_VERB_SPS00_VERBS_RARE, focusing on verb disambiguation, similar to the adjustments made in this PR.
• [pt] More verbs/nouns fixes in disambiguation.xml #11042: Renames the rule PELA_COMO_SOBRE_VERBS_RARE to PELA_COMO_SOBRE_NADA_VERBS_RARE, reflecting a similar renaming pattern as seen in this PR.
• [pt] More verbs/nouns fixes in disambiguation.xml #11052: Modifies the rule PELA_COMO_SOBRE_NADA_VERBS_RARE to include "acerca," consistent with the focus on enhancing rule specificity in this PR.
• [pt] More verbs/nouns fixes in disambiguation.xml #11056: Includes various modifications to rules related to verb and noun disambiguation, aligning with the main PR's focus on refining disambiguation rules.

Suggested reviewers

• jaumeortola: Suggested reviewer likely due to involvement in related changes or expertise in the area addressed by this PR.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (1)

Line range hint 3824-3843: Consider preserving the example comments

The removed comments contained valuable examples that helped understand the rule's application. While the examples are still valid, having them in comments helps future maintainers understand the rule's purpose and behavior.

Consider preserving these examples in the comments to maintain code documentation quality:

    </pattern>
    <disambig action="remove" postag="V.*"/>
+   <!--
+   Examples:
+            Elas eram conhecidas pelas cadelas.
+            Elas eram conhecidas como cadelas.
+            As espécies viáveis foram sendo incorporadas gradativamente pela natureza.
+            A cidade também é muito conhecida pelos seus doces de espécie.
+            Obrigado pela sua compreensão e bom trabalho!
+            A segunda, que era conhecida como sua esposa no Olimpo, era a ciumenta Hera.
+            Ele escreveu que ficou surpreso sobre como os resultados ficaram bons.
+            Se ofendem por conta de suspeitas sobre artistas.
+            Desde 1967, Ele tem derramado sobre a Igreja a graça do batismo no Espírito Santo.
+            Suponho que não há mais nada a dizer sobre isso.
+            Vamos nos separar e procurar pelo Tom.
+            Não vim aqui para falar sobre meus problemas.
+            Na audiência, nada foi comprovado acerca da alegação do convite às testemunhas.
+            Sei que tem muito jogo de cena, mas ele poderia ter escolhido ele mesmo.
+            Fala mal dela mas queria ser ela e estar no lugar dela.
+    -->

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 140f77f and 6d5dc2b.

📒 Files selected for processing (1)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (2 hunks)

🔇 Additional comments (2)

languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (2)

3816-3818: Rule ID update looks good

The rule ID change from PELA_COMO_SOBRE_NADA_ACERCA_VERBS_RARE to PELA_COMO_SOBRE_NADA_ACERCA_ELAR_VERBS_RARE accurately reflects the addition of "elar" verbs to the pattern.

---

3823-3823: Pattern update enhances disambiguation

The addition of el[ae]s? to the pattern improves disambiguation by handling pronouns like "ele", "ela", "eles", "elas" when they appear after past participles/infinitives.