Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: assembling the app features in modular way #9129

Merged
merged 11 commits into from
Nov 30, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Oct 9, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  • refactor the app preparation of app.py in modular way, by extending features with extensions
  • output the time cost of applying each extension in milseconds when launching the service, for better understanding in exact features applied and their cost in launching time
  • make DifyApp class as first class member for decoupling

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. 💪 enhancement New feature or request labels Oct 9, 2024
@bowenliang123 bowenliang123 marked this pull request as draft October 9, 2024 13:11
@bowenliang123 bowenliang123 marked this pull request as ready for review October 9, 2024 13:51
@bowenliang123 bowenliang123 changed the title refactor: the app preperation in modular style refactor: assembling the app features in modular say Oct 10, 2024
@bowenliang123 bowenliang123 changed the title refactor: assembling the app features in modular say refactor: assembling the app features in modular way Oct 10, 2024
@bowenliang123 bowenliang123 force-pushed the Improve-app branch 2 times, most recently from bd349cd to 013929f Compare October 29, 2024 12:33
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Oct 29, 2024
crazywoola
crazywoola previously approved these changes Oct 29, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 29, 2024
@laipz8200 laipz8200 self-assigned this Nov 24, 2024
@laipz8200
Copy link
Member

Please resolve the conflicts, thanks

@bowenliang123 bowenliang123 marked this pull request as draft November 27, 2024 13:56
@bowenliang123 bowenliang123 force-pushed the Improve-app branch 2 times, most recently from c48b402 to 8145ea6 Compare November 28, 2024 05:23
@bowenliang123 bowenliang123 marked this pull request as ready for review November 28, 2024 06:17
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 28, 2024
@bowenliang123
Copy link
Contributor Author

It's now ready for review again, with all conflicts resolved and changes refactored. cc @laipz8200 @crazywoola

@bowenliang123 bowenliang123 force-pushed the Improve-app branch 3 times, most recently from 612a11b to dbd2b09 Compare November 28, 2024 15:25
@laipz8200 laipz8200 merged commit 9b46b02 into langgenius:main Nov 30, 2024
6 checks passed
@bowenliang123 bowenliang123 deleted the Improve-app branch December 1, 2024 13:30
@bowenliang123
Copy link
Contributor Author

Great! Another step forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants