-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
celery worker log format following LOG_FORMAT env#9404 #10016
Conversation
Signed-off-by: root <[email protected]>
Consider merging #9129 before this PR, changing the timezone into |
Please fix the lint errors as well |
Signed-off-by: root <[email protected]>
Signed-off-by: root <[email protected]>
Signed-off-by: root <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: root <[email protected]>
…nto tag_celery
After the Code was committed, it seems that CI was not triggered, it only shows "2 workflows awaiting approval", Please tell me what might be the reason for this, thanks. @crazywoola @bowenliang123 |
Because this is your first ever PR in this repo, all workflows are executed only when the maintainer approves the runs. You may need a hand from @laipz8200 @crazywoola . Or you may test it locally and raise your screenshot evidence for passing the tests. |
I understand now, thanks |
Please rebase the main branch and fix the errors again. :) |
) Signed-off-by: root <[email protected]> Co-authored-by: root <[email protected]>
) Signed-off-by: root <[email protected]> Co-authored-by: root <[email protected]>
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsDescription
Celery worker log are output to the "LOG_FILE" env using "LOG_FORMAT" env, and use the "LOG_TZ" in env.
Fixes #9404
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration