Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api/core): Improve type hints and apply ruff formatter in agent runner and model manager. #8166

Conversation

laipz8200
Copy link
Member

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Improve type hints:

  • change some list to Sequence

Format:

  • Apply ruff formatter.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 💪 enhancement New feature or request labels Sep 9, 2024
Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 10, 2024
@crazywoola crazywoola merged commit ed37439 into main Sep 10, 2024
9 checks passed
@crazywoola crazywoola deleted the refactor/improve-type-hints-and-apply-ruff-format-in-agent-runner-and-model-manager branch September 10, 2024 07:00
Scorpion1221 added a commit to yybht155/dify that referenced this pull request Sep 10, 2024
* commit 'dabfd74622a613c7198f06791ad70424ac94f54f': (222 commits)
  feat: Parallel Execution of Nodes in Workflows (langgenius#8192)
  docs: replace docker-compose with docker compose (langgenius#8195)
  refactor(api/core): Improve type hints and apply ruff formatter in agent runner and model manager. (langgenius#8166)
  filter excel empty sheet (langgenius#8194)
  fix: The length of the tag should between 1 and 50 (langgenius#8187) (langgenius#8188)
  nvidia rerank top n missed (langgenius#8185)
  fix: Version '2.6.2-2' for 'expat' was not found (langgenius#8182)
  code merge error (langgenius#8183)
  add volcengine tos storage (langgenius#8164)
  chore: bump super-linter to v7 (langgenius#8148)
  feat(api/core/model_runtime/entities/defaults.py): Add TOP_K in default parameters. (langgenius#8167)
  Fix variable typo (cont) (langgenius#8161)
  update qwen-long (langgenius#8157)
  Update LICENSE - remove 'SaaS' from restriction term definition (langgenius#8143)
  fix: html raw render (langgenius#8138)
  chore: translate i18n files (langgenius#8135)
  fix: user-select style and pre-create iframe in embed.js (langgenius#8093)
  Modify model parameters in Spark LLMs and zhipuai LLMs (langgenius#8078)
  chore: offline n to 1 retrieval (langgenius#8134)
  fix: ollama text embedding 500 error (langgenius#8131)
  ...

# Conflicts:
#	api/configs/app_config.py
#	api/configs/feature/__init__.py
#	api/core/helper/code_executor/code_executor.py
#	api/services/conversation_service.py
#	web/yarn.lock
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 26, 2024
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants