-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(api/core): Improve type hints and apply ruff formatter in agent runner and model manager. #8166
Merged
crazywoola
merged 1 commit into
main
from
refactor/improve-type-hints-and-apply-ruff-format-in-agent-runner-and-model-manager
Sep 10, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent runner and model manager.
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
💪 enhancement
New feature or request
labels
Sep 9, 2024
bowenliang123
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
crazywoola
approved these changes
Sep 10, 2024
crazywoola
deleted the
refactor/improve-type-hints-and-apply-ruff-format-in-agent-runner-and-model-manager
branch
September 10, 2024 07:00
Scorpion1221
added a commit
to yybht155/dify
that referenced
this pull request
Sep 10, 2024
* commit 'dabfd74622a613c7198f06791ad70424ac94f54f': (222 commits) feat: Parallel Execution of Nodes in Workflows (langgenius#8192) docs: replace docker-compose with docker compose (langgenius#8195) refactor(api/core): Improve type hints and apply ruff formatter in agent runner and model manager. (langgenius#8166) filter excel empty sheet (langgenius#8194) fix: The length of the tag should between 1 and 50 (langgenius#8187) (langgenius#8188) nvidia rerank top n missed (langgenius#8185) fix: Version '2.6.2-2' for 'expat' was not found (langgenius#8182) code merge error (langgenius#8183) add volcengine tos storage (langgenius#8164) chore: bump super-linter to v7 (langgenius#8148) feat(api/core/model_runtime/entities/defaults.py): Add TOP_K in default parameters. (langgenius#8167) Fix variable typo (cont) (langgenius#8161) update qwen-long (langgenius#8157) Update LICENSE - remove 'SaaS' from restriction term definition (langgenius#8143) fix: html raw render (langgenius#8138) chore: translate i18n files (langgenius#8135) fix: user-select style and pre-create iframe in embed.js (langgenius#8093) Modify model parameters in Spark LLMs and zhipuai LLMs (langgenius#8078) chore: offline n to 1 retrieval (langgenius#8134) fix: ollama text embedding 500 error (langgenius#8131) ... # Conflicts: # api/configs/app_config.py # api/configs/feature/__init__.py # api/core/helper/code_executor/code_executor.py # api/services/conversation_service.py # web/yarn.lock
cuiks
pushed a commit
to cuiks/dify
that referenced
this pull request
Sep 26, 2024
…ent runner and model manager. (langgenius#8166)
lau-td
pushed a commit
to heydevs-io/dify
that referenced
this pull request
Oct 23, 2024
…ent runner and model manager. (langgenius#8166)
idonotknow
pushed a commit
to AceDataCloud/Dify
that referenced
this pull request
Nov 16, 2024
…ent runner and model manager. (langgenius#8166)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💪 enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsDescription
Improve type hints:
list
toSequence
Format:
Fixes
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration