Moved restart into pairing mode code to Microbit.cpp #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-sam
force-pushed
the
reset-pairing-mode
branch
from
9f77398
to
cf11a85
Compare
|
@microbit-sam can we include the change to the module.json file to point to the new DAL release (once that's happened) in this PR, so it gets merged as one? |
microbit-sam
commented
Nov 23, 2018
| @@ -121,7 +121,7 @@ void MicroBit::init() | |||
| // Create an event handler to trap any handlers being created for I2C services. | |||
| // We do this to enable initialisation of those services only when they're used, | |||
| // which saves processor time, memeory and battery life. | |||
| messageBus.listen(MICROBIT_ID_MESSAGE_BUS_LISTENER, MICROBIT_EVT_ANY, this, &MicroBit::onListenerRegisteredEvent); | |||
| messageBus.listen(MICROBIT_ID_ANY, MICROBIT_EVT_ANY, this, &MicroBit::onListenerRegisteredEvent); | |||
There was a problem hiding this comment.
Joe suggests creating a new MICROBIT_ID_SYSTEM event to prevent churn
- Things like the accelerometer will constantly be firing events at this
- A system event could be used for other things
There was a problem hiding this comment.
MICROBIT_ID_MESSAGE_BUS_LISTENER renamed to SYSTEM
|
Superseded by #15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lancaster-university/microbit-dal#395