Moved restart into pairing mode code to Microbit.cpp #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-sam
changed the title
|
Hi @pelikhan Yes we should. Apologies for being distracted this week - start of term in universities in the UK, so I've had to prioritize other things. Let's discuss in our upcoming call. |
|
Hey @finneyj - any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#392
Moved the restart into pairing mode code to Microbit.cpp
It's #ifdef guarded to only compile if pairing mode exists in the build
I've left the source of the event here as MICROBIT_ID_PARTIAL_FLASHING. The event listener used now listens for any source but it may be useful in the future to know where the request to enter pairing mode has come from
lancaster-university/microbit#13