Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Native erc20 deposit integration tests #52

Merged
merged 21 commits into from
Feb 2, 2024
Merged

test: Native erc20 deposit integration tests #52

merged 21 commits into from
Feb 2, 2024

Conversation

jrchatruc
Copy link
Collaborator

@jrchatruc jrchatruc commented Jan 17, 2024 •
edited by SantiagoPittella
Loading

closes #29

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.

@SantiagoPittella SantiagoPittella changed the title Native erc20 deposit integration tests test: Native erc20 deposit integration tests Jan 18, 2024
juanbono
juanbono previously approved these changes Jan 22, 2024
View reviewed changes
Copy link

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SantiagoPittella SantiagoPittella enabled auto-merge (squash) January 22, 2024 13:47
@jrchatruc jrchatruc merged commit 760d0b9 into native_erc20 Feb 2, 2024
11 of 15 checks passed
@jrchatruc jrchatruc deleted the native_erc20_test_deposit branch February 2, 2024 15:41
@jrchatruc jrchatruc mentioned this pull request Feb 6, 2024
Closed
Oppen pushed a commit that referenced this pull request Feb 9, 2024
@koloz193
updated hh version and solidity version (#52)
6ce4f8f 
* updated hh version and solidity version

* removed carrot

* formatting

* fixed compiler versions

* updated yul compiler version

* update hash file

* changed OZ contracts back

* update hash file

* changed compiler version

* bumped utils compiler version and hashes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanbono juanbono juanbono approved these changes

@mationorato mationorato Awaiting requested review from mationorato mationorato is a code owner

@ilitteri ilitteri Awaiting requested review from ilitteri ilitteri is a code owner

@IAvecilla IAvecilla Awaiting requested review from IAvecilla IAvecilla is a code owner

Assignees
No one assigned
Labels
external-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrchatruc @juanbono @fkrause98 @juan518munoz @SantiagoPittella