Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for deposits #29

Closed
jrchatruc opened this issue Jan 10, 2024 · 0 comments
Closed

Add tests for deposits #29

jrchatruc opened this issue Jan 10, 2024 · 0 comments
Assignees
@SantiagoPittella
Labels
erc20-base-token

Comments

@jrchatruc
Copy link
Collaborator

jrchatruc commented Jan 10, 2024 •
edited
Loading

Closes #52

🌟 Feature Request

📝 Description

The following tests should be added:

  • One that does a regular valid deposit and checks that:
    • The native balance on the L2 increase by the amount deposited.
    • The ERC20 balance on the L1 decreased by that same amount plus a bit more (accounting for the operator fee).
    • The eth balance on the L1 decreased, but only to cover the deposit transaction fee on the L1.
  • One that ensures that no one can deposit more money than they have.
@SantiagoPittella SantiagoPittella mentioned this issue Jan 18, 2024
Merged
5 tasks
toni-calvin pushed a commit that referenced this issue Aug 8, 2024
@kelemeno @benceharomi
@vladbochok @ilitteri @popzxc @dimazhornyk @Raid5594 @saxenism @StanislavBreadless
feat(): v0 shared bridge (#29)
1328226 
Co-authored-by: Bence Haromi <[email protected]>
Co-authored-by: vladbochok <[email protected]>
Co-authored-by: Vlad Bochok <[email protected]>
Co-authored-by: ilitteri <[email protected]>
Co-authored-by: Santiago Pittella <[email protected]>
Co-authored-by: Ivan Litteri <[email protected]>
Co-authored-by: Igor Aleksanov <[email protected]>
Co-authored-by: Dima Zhornyk <[email protected]>
Co-authored-by: Raid Ateir <[email protected]>
Co-authored-by: Raid Ateir <[email protected]>
Co-authored-by: dimazhornyk <[email protected]>
Co-authored-by: Raid5594 <[email protected]>
Co-authored-by: Rahul Saxena <[email protected]>
Co-authored-by: Stanislav Breadless <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SantiagoPittella SantiagoPittella

Labels
erc20-base-token
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrchatruc @SantiagoPittella