Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labgrid/driver/power: deprecate siglent backend #1509

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ Due to the migration, 24.1 includes the following breaking changes:
Other breaking changes include:

- Support for Python 3.8 was dropped.
- The siglent power backend is deprecated because it uses the no longer
maintained vxi11 module which again uses the deprecated (and in Python 3.13
removed) xdrlib. See
`issue #1507 <https://github.com/labgrid-project/labgrid/issues/1507>`_.

Known issues in 24.1
~~~~~~~~~~~~~~~~~~~~
Expand Down
12 changes: 12 additions & 0 deletions labgrid/driver/power/siglent.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,16 @@
""" tested with Siglent SPD3303X-E, and should be compatible with all SPD3000X series modules"""

import warnings

import vxi11


def power_set(host, port, index, value):
warnings.warn(
"siglent power backend uses vxi11 module using deprecated xdrlib module, see https://github.com/labgrid-project/labgrid/issues/1507",
DeprecationWarning,
)

assert port is None
index = int(index)
assert 1 <= index <= 2
Expand All @@ -13,6 +20,11 @@ def power_set(host, port, index, value):


def power_get(host, port, index):
warnings.warn(
"siglent power backend uses vxi11 module using deprecated xdrlib module, see https://github.com/labgrid-project/labgrid/issues/1507",
DeprecationWarning,
)

assert port is None
index = int(index)
assert 1 <= index <= 2
Expand Down