Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labgrid/driver/power: deprecate siglent backend #1509

Merged

Conversation

Bastian-Krause
Copy link
Member

Description
Deprecate the siglent power backend: It uses the no longer maintained vxi11 module which again uses the deprecated (and in Python 3.13 removed) xdrlib. See issue #1507.

@Bastian-Krause Bastian-Krause changed the title labgrid/driver/power: depcrecate siglent backend labgrid/driver/power: decrecate siglent backend Sep 30, 2024
@Bastian-Krause
Copy link
Member Author

Fixed typo in commit message.

@Bastian-Krause Bastian-Krause changed the title labgrid/driver/power: decrecate siglent backend labgrid/driver/power: deprecate siglent backend Sep 30, 2024
See labgrid-project#1507 for more
details.

Signed-off-by: Bastian Krause <[email protected]>
@Bastian-Krause
Copy link
Member Author

Rebased on latest master.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.6%. Comparing base (7ab6240) to head (809b286).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
labgrid/driver/power/siglent.py 33.3% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1509     +/-   ##
========================================
- Coverage    56.7%   56.6%   -0.1%     
========================================
  Files         168     168             
  Lines       13022   13025      +3     
========================================
+ Hits         7384    7385      +1     
- Misses       5638    5640      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Emantor Emantor merged commit 8d67b3b into labgrid-project:master Oct 21, 2024
8 of 10 checks passed
@Bastian-Krause Bastian-Krause deleted the bst/deprecate-siglent branch October 21, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants