Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise warning for torch double backward #141

Merged
merged 19 commits into from
Sep 2, 2024
Merged

Conversation

frostedoyster
Copy link
Collaborator

After discussing #139, @Luthaf and I came to the conclusion that we can't do much without sacrificing a lot of performance in the important case where only mixed derivatives are needed. Therefore, we're adding a warning and thoroughly documenting the potential issues that can arise

@frostedoyster frostedoyster requested a review from Luthaf August 27, 2024 12:42
@frostedoyster frostedoyster changed the base branch from main to new-api August 27, 2024 12:42
@frostedoyster frostedoyster force-pushed the torch-double-backward-rework branch from 6e9230b to abd0d25 Compare August 27, 2024 12:48
Copy link

github-actions bot commented Aug 27, 2024

Here is a pre-built version of the code in this pull request: wheels.zip, you can install it locally by unzipping wheels.zip and using pip to install the file matching your system

@ceriottm
Copy link
Contributor

Makes sense, we can't get around the limitations of torch.

@Luthaf
Copy link
Contributor

Luthaf commented Aug 27, 2024

The changes looks good but CI failure is strange here

@ceriottm
Copy link
Contributor

The changes looks good but CI failure is strange here

Guess you'll have to test this - neither Filippo nor I have eaten from the tree of vendor lock-in

@frostedoyster frostedoyster changed the base branch from new-api to main August 28, 2024 20:48
@ceriottm ceriottm force-pushed the torch-double-backward-rework branch from 6da2942 to 9d20128 Compare September 1, 2024 17:56
@ceriottm
Copy link
Contributor

ceriottm commented Sep 1, 2024

ok I reverted all my foolish attempts to fix the CI

@Luthaf
Copy link
Contributor

Luthaf commented Sep 2, 2024

I can not reproduce the issue locally, but I just realized that CI was still using macos-13 runner, which is x86_64. Torch is no longer supporting this architecture, so I switched to macos-14 runner, which is arm64. If this fixes CI I think we are good to go, this could be an architecture-specific bug, or a bug with older versions of torch.

@frostedoyster
Copy link
Collaborator Author

Thanks for the fix!

@ceriottm ceriottm merged commit 2bee94d into main Sep 2, 2024
10 checks passed
@ceriottm ceriottm deleted the torch-double-backward-rework branch September 2, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants