-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise warning for torch double backward #141
Conversation
…::CustomClassHolder`
6e9230b
to
abd0d25
Compare
Here is a pre-built version of the code in this pull request: wheels.zip, you can install it locally by unzipping |
Makes sense, we can't get around the limitations of torch. |
The changes looks good but CI failure is strange here |
Guess you'll have to test this - neither Filippo nor I have eaten from the tree of vendor lock-in |
6da2942
to
9d20128
Compare
ok I reverted all my foolish attempts to fix the CI |
I can not reproduce the issue locally, but I just realized that CI was still using macos-13 runner, which is x86_64. Torch is no longer supporting this architecture, so I switched to macos-14 runner, which is arm64. If this fixes CI I think we are good to go, this could be an architecture-specific bug, or a bug with older versions of torch. |
Thanks for the fix! |
After discussing #139, @Luthaf and I came to the conclusion that we can't do much without sacrificing a lot of performance in the important case where only mixed derivatives are needed. Therefore, we're adding a warning and thoroughly documenting the potential issues that can arise