Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation review #143

Merged
merged 15 commits into from
Sep 1, 2024
Merged

Documentation review #143

merged 15 commits into from
Sep 1, 2024

Conversation

frostedoyster
Copy link
Collaborator

@frostedoyster frostedoyster commented Aug 28, 2024

Attempt to update and clean up the documentation.
Preview: https://sphericart--143.org.readthedocs.build/en/143/

Copy link

github-actions bot commented Aug 28, 2024

Here is a pre-built version of the code in this pull request: wheels.zip, you can install it locally by unzipping wheels.zip and using pip to install the file matching your system

@frostedoyster frostedoyster force-pushed the documentation-reveiw branch 2 times, most recently from e552a51 to 30acb1c Compare August 29, 2024 06:56
@frostedoyster frostedoyster marked this pull request as ready for review August 29, 2024 07:12
@frostedoyster
Copy link
Collaborator Author

frostedoyster commented Aug 29, 2024

I haven't touched the CUDA C++ and torch docs yet. I think we should wait for CUDA C++ to match the C++ API and for #141 to be merged. Everything else should be ready

EDIT: updated CUDA C++ docs

@ceriottm
Copy link
Contributor

The CUDA c++ example seems to imply that there is just compute, but the API also specify compute_with_gradient and compute_with_hessian - I suspect it needs updating.

@ceriottm ceriottm merged commit b8c9d10 into main Sep 1, 2024
10 checks passed
@ceriottm ceriottm deleted the documentation-reveiw branch September 1, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants