proposal: add proposal for unified backup #374
Conversation
|
@Xieql: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kurator-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Xieql <[email protected]>
Signed-off-by: Xieql <[email protected]>
Signed-off-by: Xieql <[email protected]>
docs/proposals/backup/backup.md
Outdated
|
|
||
| - **Version Compatibility** | ||
| As mentioned, different versions of Velero have different fields. | ||
| There's a risk of compatibility issues if clusters are running different versions. It's crucial to ensure all clusters run a supported version of Velero. |
There was a problem hiding this comment.
we should only make use of the latest version, so do we face this issue?
There was a problem hiding this comment.
yes, it is recommended that users use a newer version of Kubernetes, as older versions are not tested with Velero.
docs/proposals/backup/backup.md
Outdated
| // ItemOperationTimeout specifies the time used to wait for asynchronous BackupItemAction operations. | ||
| // The default value is 1 hour. | ||
| // +optional | ||
| ItemOperationTimeout metav1.Duration `json:"itemOperationTimeout,omitempty"` |
There was a problem hiding this comment.
s/ItemOperationTimeout/Timeout
It is under backup, so we can simplify calling timeout
There was a problem hiding this comment.
we can just remove it and using default value.
docs/proposals/backup/backup.md
Outdated
| ExcludedNamespaces []string `json:"excludedNamespaces,omitempty"` | ||
|
|
||
| // IncludedResources is a slice of resource names to include in the backup. | ||
| // For example, we can populate this string array with "deployments" and "configmaps", then we will select all resources of type deployments and configmaps, |
There was a problem hiding this comment.
Take it as an example ["deployments", "configmaps"]
There was a problem hiding this comment.
I'm not quite sure what 'Take it as an example ["deployments", "configmaps"]' means
There was a problem hiding this comment.
Please check what is a good example, i mean here you want to express what this example means.
So I suggested ["deployments", "configmaps"]
There was a problem hiding this comment.
I got it, ["deployments", "configmaps"] would be a better expresssion
Signed-off-by: Xieql <[email protected]>
Signed-off-by: Xieql <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind design
/kind documentation
What this PR does / why we need it:
add proposal aimed to enhance Kurator by introducing unified backup, restore, and migration capabilities.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: