backup: init backup controller #394
Conversation
✅ Deploy Preview for kurator-dev canceled.
|
Xieql
force-pushed
the
init-backup-controller
branch
2 times, most recently
from
f05c19b to
77c5619
Compare
Signed-off-by: Xieql <[email protected]>
Xieql
force-pushed
the
init-backup-controller
branch
from
77c5619 to
139f0d2
Compare
|
@hzxuzhonghu PTAL |
There was a problem hiding this comment.
nit: prefer move it in backup pkg
| return len(backup.Spec.Schedule) != 0 | ||
| } | ||
|
|
||
| func generateVeleroInstanceLabel(createdByLabel, creatorName, fleetName string) map[string]string { |
There was a problem hiding this comment.
nit: we have many duplicate calling these
There was a problem hiding this comment.
could you please clarify what you mean by 'many duplicate calling these'? Can you point to specific instances or suggest how I might address this?
There was a problem hiding this comment.
I mean we set labels in many different places
There was a problem hiding this comment.
refactor them in subsequent PRs.
Xieql
force-pushed
the
init-backup-controller
branch
4 times, most recently
from
cde0da7 to
ee38a5a
Compare
Signed-off-by: Xieql <[email protected]>
Xieql
force-pushed
the
init-backup-controller
branch
from
ee38a5a to
ddbf7a7
Compare
| return len(backup.Spec.Schedule) != 0 | ||
| } | ||
|
|
||
| func generateVeleroInstanceLabel(createdByLabel, creatorName, fleetName string) map[string]string { |
There was a problem hiding this comment.
I mean we set labels in many different places
Signed-off-by: Xieql <[email protected]>
Xieql
force-pushed
the
init-backup-controller
branch
from
f0dea62 to
1d4ab8b
Compare
|
/label tide/merge-method-squash |
|
Please donot force push, so we can review the delta commit. When it is ready, we should squash then |
In fact, this force submission made the delta commit more clear. I won't force a submission casually. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
It will help the reviewers to review only the delta change |
ok |
What type of PR is this?
/kind feature
What this PR does / why we need it:
init the Backup controller.
in addition, refactor the
client.goto getclient.Clientfromsigs.k8s.io/controller-runtime/pkg/clientpart of #377
part of #374
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: