Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navbar Enhanced to be responsive and new working links #4802

Merged
merged 4 commits into from
Jul 14, 2024
Merged

Navbar Enhanced to be responsive and new working links #4802

merged 4 commits into from
Jul 14, 2024

Conversation

mohitgedar
Copy link
Contributor

PR Description 📜

Fixes #4801

I have made changes to make the main websites navbar responsive and working .

  • I have added media queries so that the navbar responds well to different screen sizes
  • I have added a new Link Contact in the navbar to go to contact section at the end of website
  • I have updated html file so that the links already present works now , before they were just sitting there
  • I have fixed the navbar to the top , so that it can be used to navigate through the website.
  • I have removed unnecessary CSS rule from both style.css and navbar.css, that were not used anywhere so that maintaining the website becomes easy , right now it's very hard to navigate through
  • I have place the theme-toggle button in the navbar , perfectly aligned with other items so that now it don't look like a alien on the page but a part of the website.
  • Now GameZone logo also works as a clickable element in the navbar.

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added youtube link for preview before and after changes.
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Preview videos are of large size so uploaded on youtube. Links below.


Thank you soo much for contributing to our repository 💗

@mohitgedar
updated gameData.json
34a4938 
I have updated this file so that new games can be added in the end easily and on the main website the no. of games is generated sequencly as they are generated using the key from the JSON object.
@mohitgedar
remove unnecessary styles and update necessary ones in navbar.css
8dcff86 
I have removed unnecessary styles from the style.css as they were not applied to any element , and have updated navbar.css for the necessary ones
@mohitgedar
updated navbar.css with new changes
0acfe46 
I have updated this file to remove outdated Css and updated the Css to make the navbar responsive with media queries .
@mohitgedar
updated index.html
3115bc9 
I have updated this file so that the links of the navbar works , also added one more button to go to the contact section
@kunjgit
Copy link
Owner

kunjgit commented Jul 10, 2024

Thank you @mohitgedar ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@mohitgedar mohitgedar mentioned this pull request Jul 13, 2024
Merged
7 tasks
@mohitgedar
Copy link
Contributor Author

@ishita-43 what's the update ?

ishita-43
ishita-43 approved these changes Jul 14, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did good work !! 👍

@ishita-43 ishita-43 added level2 Enhancement in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jul 14, 2024
@kunjgit kunjgit merged commit cb956e3 into kunjgit:main Jul 14, 2024
3 checks passed
@kunjgit
Copy link
Owner

kunjgit commented Jul 14, 2024

Thank you @mohitgedar , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishita-43 ishita-43 ishita-43 approved these changes

Assignees
No one assigned
Labels
gssoc GSSoC24 program label level2 Enhancement in gssoc Ready to merge 🥳
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Enhanced the navbar of the main website
3 participants
@mohitgedar @kunjgit @ishita-43