Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributors Link fixed and Games Link added #4825

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

shreyasmunge
Copy link
Contributor

PR Description 📜

The contributors link in the Navbar was not working, and the games link was missing. I reviewed index.html to identify the issue, corrected the contributors link, and added a new link called "Games" in the navbar.
Fixes #4818


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Issue_4818.mp4


Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jul 12, 2024

Thank you @shreyasmunge ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@mohitgedar
Copy link
Contributor

hey,
This issue of contributors link not working along with others is already addressed in the PR #4802

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!!

@ishita-43 ishita-43 added Ready to merge 🥳 gssoc GSSoC24 program label labels Jul 14, 2024
@shreyasmunge
Copy link
Contributor Author

@kunjgit and @ishita-43 I have resolved the merge conflicts, Please have a look .

@mohitgedar
Copy link
Contributor

mohitgedar commented Jul 15, 2024

hey, did you check how navbar responds for adding new element ,for different screen sizes . you can check that by right click then going to inspect and pressing ctrl+shift+M , and then draging the screen using || on RHS of screen to see response of the navbar.

According to me one extra element will cause overflow of elements in navbar for small screen size

https://www.youtube.com/watch?v=5AdKy41FcVY for your reference

@kunjgit kunjgit merged commit 8282640 into kunjgit:main Jul 15, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jul 15, 2024

Thank you @shreyasmunge , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

@shreyasmunge
Copy link
Contributor Author

shreyasmunge commented Jul 16, 2024

@ishita-43 and @kunjgit Please add Level Label and assignees to this PR .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Fix Contributors Link and Add Games Link in Navbar
4 participants