-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributors Link fixed and Games Link added #4825
Conversation
Thank you @shreyasmunge ,for creating the PR and contributing to our GameZone 💗 |
hey, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!!
@kunjgit and @ishita-43 I have resolved the merge conflicts, Please have a look . |
hey, did you check how navbar responds for adding new element ,for different screen sizes . you can check that by right click then going to inspect and pressing ctrl+shift+M , and then draging the screen using || on RHS of screen to see response of the navbar. According to me one extra element will cause overflow of elements in navbar for small screen size https://www.youtube.com/watch?v=5AdKy41FcVY for your reference |
Thank you @shreyasmunge , for your valuable time and contribution in our GameZone 💗. |
@ishita-43 and @kunjgit Please add Level Label and assignees to this PR . |
PR Description 📜
The contributors link in the Navbar was not working, and the games link was missing. I reviewed index.html to identify the issue, corrected the contributors link, and added a new link called "Games" in the navbar.
Fixes #4818
Mark the task you have completed ✅
Add your screenshots(Optional) 📸
Issue_4818.mp4
Thank you soo much for contributing to our repository 💗