Add Date range filter #754
Conversation
There was a problem hiding this comment.
Before we proceed with this filter's development, it's essential to finalize the single date filter. By doing so, we can identify methods and utilities that are reusable across multiple date filters. This approach will not only ensure consistency but also make our development process more efficient. By designing the single date filter with modularity in mind, we can potentially share a significant portion of its functionality with this and other date filters. This will help us maintain a unified codebase and enhance the overall efficiency.
rszwajko
force-pushed
the
rangeFilter
branch
2 times, most recently
from
f442d71 to
ee48822
Compare
After our discussion in the mtg, I did some google searches about the meaning of It seems the use of 'to' in date ranges can be context-dependent. For hours, like '3:00 to 5:00', it might often mean up to, but not including 5:01. However, for days, such as 'Sunday to Thursday', it usually includes the entirety of Thursday. The terms 'until' and 'through' provide clearer distinctions for exclusivity and inclusivity, respectively. Nevertheless, the key takeaway appears to be: for clarity and precision, it's always beneficial to specify explicitly. My conclusion: [1] https://www.reddit.com/r/grammar/comments/7nsih7/tountil_including_date/?rdt=40133 |
|
After our discussion in the mtg, about the chip height, |
rszwajko
force-pushed
the
rangeFilter
branch
2 times, most recently
from
a87943e to
6cfeb04
Compare
|
@yaacov |
Allow to filter events that belong to a time interval. Precisely given range [A,B) a date X in the range if A <= X < B. Key points: 1) multiple date ranges can be chosen 2) ISO time interval format is used to represent the range. Only date part is used (no time, no time zone) 3) the range is interpreted in UTC Reference-Url: https://en.wikipedia.org/wiki/ISO_8601#Time_intervals Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Run date related tests additionally in UTC+02:00 zone. Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Display the entire interval string in a tooltip. Time intervals as text are too long to be displayed in a chip. The text is truncated which hides the end date. Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
|
can you add a space between the bottom ant the help comment ?
example of a gap below a help text and next item:
|
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
|
@yaacov |
|
Kudos, SonarCloud Quality Gate passed!
|
Create a filter widget based on DateRangeFilter developed for Forklift plugin. Use the new widget to filter migration waves on both start and end date. Key points: 1. filter values are stored as strings in ISO 8601 time interval format (date part only) i.e. "2024-04-01/2024-05-01". 2. date range is a closed range (both ends are included) 3. browser local time zone is used 4. date format is hard-coded to "MM/DD/YYYY" to match the format used in the UI Additional changes: 1. force TZ=UTC for jest unit tests to ensure the same test results 2. initialize dayjs plugins for tests Reference-Url: kubev2v/forklift-console-plugin#754 Reference-Url: https://en.wikipedia.org/wiki/ISO_8601#Time_intervals Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Create a filter widget based on DateRangeFilter developed for Forklift plugin. Use the new widget to filter migration waves on both start and end date. Key points: 1. filter values are stored as strings in ISO 8601 time interval format (date part only) i.e. "2024-04-01/2024-05-01". 2. date range is a closed range (both ends are included) 3. browser local time zone is used 4. date format is hard-coded to "MM/DD/YYYY" to match the format used in the UI Additional changes: 1. force TZ=UTC for jest unit tests to ensure the same test results 2. initialize dayjs plugins for tests Reference-Url: kubev2v/forklift-console-plugin#754 Reference-Url: https://en.wikipedia.org/wiki/ISO_8601#Time_intervals Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Create a filter widget based on `DateRangeFilter` developed for Forklift plugin. Use the new widget to filter migration waves on both start and end date. Key points: 1. filter values are stored as strings in ISO 8601 time interval format (date part only) i.e. "2024-04-01/2024-05-01". 2. date range is a closed range (both ends are included) 3. browser local time zone is used 4. date format is hard-coded to "MM/DD/YYYY" to match the format used in the UI Additional changes: 1. force TZ=UTC for jest unit tests to ensure the same test results 2. initialize dayjs plugins for tests Reference-Url: kubev2v/forklift-console-plugin#754 Reference-Url: https://en.wikipedia.org/wiki/ISO_8601#Time_intervals Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Depends on #747
Allow to filter events that belong to a time interval.
Precisely given range [A,B) a date X in the range if A <= X < B.EDIT: changed to closed range
Key points:
part is used (no time, no time zone)
Reference-Url: https://en.wikipedia.org/wiki/ISO_8601#Time_intervals
Additional changes: