-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time range filter category type, use instead of search filter for filtering on timestamps #127
Comments
There is now a time picker component as well: https://www.patternfly.org/v4/components/time-picker But, there still isn't a good way to make a control for selecting a range from start date AND time to end date and time. The date picker component has date range support, but doesn't include times. And the time picker component doesn't include dates. So we'd have to come up with a design that involves some kind of dropdown with 4 fields (start date, start time, end date, end time) which may be better addressed in PF itself. I think maybe the next step here is to bring up the requirement with a PF issue and see what we could do about this at the design level. |
This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
Noticed this in kubev2v/forklift-ui#142. The filters for start and end time should ideally be a date/time range picker instead of a search filter, but we don't quite have support for that in PF or FilterToolbar yet. There is a beta component https://www.patternfly.org/v4/components/date-picker we can use in the future, but it doesn't support times and ranges yet, and then once it does we'll also need to add a new type of FilterCategory for time ranges.
Opening this issue so we don't forget about this, but it's blocked by PatternFly for now.
The text was updated successfully, but these errors were encountered: