Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time range filter category type, use instead of search filter for filtering on timestamps #127

Closed
mturley opened this issue Oct 22, 2020 · 5 comments
Assignees
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. Stale
Milestone

Comments

@mturley
Copy link
Contributor

mturley commented Oct 22, 2020

Noticed this in kubev2v/forklift-ui#142. The filters for start and end time should ideally be a date/time range picker instead of a search filter, but we don't quite have support for that in PF or FilterToolbar yet. There is a beta component https://www.patternfly.org/v4/components/date-picker we can use in the future, but it doesn't support times and ranges yet, and then once it does we'll also need to add a new type of FilterCategory for time ranges.

Opening this issue so we don't forget about this, but it's blocked by PatternFly for now.

@mturley mturley changed the title [Post-beta] Add time range filter category type, use instead of search filter for filtering on timestamps Add time range filter category type, use instead of search filter for filtering on timestamps Nov 5, 2020
@mturley mturley added the enhancement Categorizes issue or PR as related to a new feature. label Nov 20, 2020
@mturley
Copy link
Contributor Author

mturley commented Jun 22, 2021

There is now a time picker component as well: https://www.patternfly.org/v4/components/time-picker

But, there still isn't a good way to make a control for selecting a range from start date AND time to end date and time. The date picker component has date range support, but doesn't include times. And the time picker component doesn't include dates. So we'd have to come up with a design that involves some kind of dropdown with 4 fields (start date, start time, end date, end time) which may be better addressed in PF itself.

I think maybe the next step here is to bring up the requirement with a PF issue and see what we could do about this at the design level.

@yaacov yaacov transferred this issue from kubev2v/forklift-ui Jan 12, 2023
@yaacov yaacov added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed enhancement Categorizes issue or PR as related to a new feature. labels Jan 12, 2023
@github-actions
Copy link

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label May 22, 2023
@yaacov yaacov removed the Stale label May 22, 2023
@github-actions
Copy link

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Sep 20, 2023
@yaacov yaacov removed the Stale label Sep 20, 2023
Copy link

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Jan 19, 2024
@yaacov
Copy link
Member

yaacov commented Jan 19, 2024

addressed by: #754

cc:// @rszwajko

@yaacov yaacov closed this as completed Jan 19, 2024
@yaacov yaacov added this to the 2.6.0 milestone Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. Stale
Projects
None yet
Development

No branches or pull requests

3 participants