For VDDK help text - replace the example with a format #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: https://issues.redhat.com/browse/MTV-1552 To avoid users from using the URL example which was provided for the Vsphere's VDDK help text field, replace it with a format suggestion. This is relevant for the create, edit, tooltip fields for all validaiton statuses (error, success, default). Signed-off-by: Sharon Gratch <[email protected]>
|
|
cc: @RichardHoch |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1389 +/- ##
==========================================
- Coverage 36.81% 36.16% -0.65%
==========================================
Files 158 158
Lines 2548 2577 +29
Branches 599 616 +17
==========================================
- Hits 938 932 -6
- Misses 1428 1450 +22
- Partials 182 195 +13 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
/lgtm |
metalice
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://issues.redhat.com/browse/MTV-1552
To avoid users from using the URL example which was provided for the Vsphere's VDDK help text field (.....
for example: quay.io/kubev2v/vddk:latest) ,replace the help text to use a format suggestion instead (...
in the format of <registry_route_or_server_path>/vddk:<tag> ..)This is relevant for the create, edit, tooltip fields for all validaiton statuses (error, success, default).
Screenshots
Before
After