Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For VDDK help text - replace the example with a format - step 2 #1390

Conversation

sgratch
Copy link
Collaborator

@sgratch sgratch commented Nov 21, 2024

Reference: https://issues.redhat.com/browse/MTV-1552
A follow up of #1389

Rephrasing the text messages based on doc and UX review.

Few screenshots

Screenshot from 2024-11-21 21-02-44

Screenshot from 2024-11-21 21-03-15

Screenshot from 2024-11-21 21-03-36

Reference: https://issues.redhat.com/browse/MTV-1552

Rephrasing the text messages based on doc and UX review.

Signed-off-by: Sharon Gratch <[email protected]>
@sgratch sgratch requested a review from yaacov November 21, 2024 19:04
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.16%. Comparing base (13484d0) to head (6de5690).
Report is 124 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1390      +/-   ##
==========================================
- Coverage   36.81%   36.16%   -0.65%     
==========================================
  Files         158      158              
  Lines        2548     2577      +29     
  Branches      599      614      +15     
==========================================
- Hits          938      932       -6     
- Misses       1428     1450      +22     
- Partials      182      195      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sgratch sgratch added the bug Categorizes issue or PR as related to a bug. label Nov 21, 2024
@sgratch sgratch added this to the 2.8.0 milestone Nov 21, 2024
@yaacov yaacov merged commit 27ef3b4 into kubev2v:main Nov 24, 2024
10 checks passed
@sgratch sgratch modified the milestones: 2.8.0, 2.7.6 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants