🐾 Update to PF5 - part II - handle rest of event handlers #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaacov
reviewed
Jul 17, 2024
| @@ -57,7 +57,10 @@ export const AutocompleteFilter = ({ | |||
|
|
|||
| const options = validSupported.map(({ label }) => <SelectOption key={label} value={label} />); | |||
|
|
|||
| const onFilter = (_, textInput) => { | |||
| const onFilter: ( | |||
| e: React.ChangeEvent<HTMLInputElement> | null, | |||
There was a problem hiding this comment.
Suggested change
| e: React.ChangeEvent<HTMLInputElement> | null, | |
| event: React.ChangeEvent<HTMLInputElement> | null, |
yaacov
reviewed
Jul 17, 2024
| @@ -350,6 +350,27 @@ export function StandardPage<T>({ | |||
| .filter((field) => field.filter?.primary) | |||
| .map(toFieldFilter(sortedData)); | |||
|
|
|||
| const onSetPage: ( | |||
| _evt: React.MouseEvent | React.KeyboardEvent | MouseEvent, | |||
There was a problem hiding this comment.
Suggested change
| _evt: React.MouseEvent | React.KeyboardEvent | MouseEvent, | |
| _event: React.MouseEvent | React.KeyboardEvent | MouseEvent, |
yaacov
added
the
enhancement
sgratch
force-pushed
the
handle_rest_of_event_handler_for_pf5
branch
from
219d5ff to
24c1c1f
Compare
yaacov
reviewed
Jul 18, 2024
| @@ -87,7 +87,10 @@ export const GroupedEnumFilter = ({ | |||
| </SelectGroup> | |||
| )); | |||
|
|
|||
| const onFilter = (_, textInput) => { | |||
| const onFilter: ( | |||
| e: React.ChangeEvent<HTMLInputElement> | null, | |||
yaacov
reviewed
Jul 18, 2024
| }; | ||
|
|
||
| const onPerPageSelect: ( | ||
| _evt: React.MouseEvent | React.KeyboardEvent | MouseEvent, |
sgratch
force-pushed
the
handle_rest_of_event_handler_for_pf5
branch
from
24c1c1f to
c2c5baa
Compare
yaacov
reviewed
Jul 18, 2024
| @@ -350,6 +350,27 @@ export function StandardPage<T>({ | |||
| .filter((field) => field.filter?.primary) | |||
| .map(toFieldFilter(sortedData)); | |||
|
|
|||
| const onSetPage: ( | |||
| _event: React.MouseEvent | React.KeyboardEvent | MouseEvent, | |||
There was a problem hiding this comment.
Suggested change
| _event: React.MouseEvent | React.KeyboardEvent | MouseEvent, | |
| event: React.MouseEvent | React.KeyboardEvent | MouseEvent, |
no need for _ in the type definition
There was a problem hiding this comment.
Correct, but this is how it was declared in PF for the function so I wanted to keep the same signature as much as possible.
https://github.com/patternfly/patternfly-react/blob/db0cdde6e3e6ae61348129b73bb43c97a98b4617/packages/react-core/src/components/Pagination/Pagination.tsx#L82
Anyway, I can see now that it was fixed for PF react 5, so will fix it in our code as well.
yaacov
reviewed
Jul 18, 2024
| }; | ||
|
|
||
| const onPerPageSelect: ( | ||
| _event: React.MouseEvent | React.KeyboardEvent | MouseEvent, |
There was a problem hiding this comment.
Reference: kubev2v#1098 For avoiding uncaught PF 4 -> PF 5 migration errors, this PR named and typed (i.e. (add type to function signature) the following callbacks appearances which use parameters: onFilter onTextInput onClear onDrop onInputKeyDown onSetPage onPerPageSelect onUserMinus onUserPlus onDataChange onTextChange Signed-off-by: Sharon Gratch <[email protected]>
sgratch
force-pushed
the
handle_rest_of_event_handler_for_pf5
branch
from
c2c5baa to
60691e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #1098
For avoiding uncaught PF 4 -> PF 5 migration errors, this PR named and typed (i.e, add type to function signature) the following callbacks appearances which use parameters:
onFilteronTextInputonClearonDroponInputKeyDownonSetPageonPerPageSelectonUserMinusonUserPlusonDataChangeonTextChange