Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐾 Update to PF5 - part II #1098

Closed
yaacov opened this issue Apr 11, 2024 · 3 comments
Closed

🐾 Update to PF5 - part II #1098

yaacov opened this issue Apr 11, 2024 · 3 comments
Assignees
@sgratch
Labels
enhancement Categorizes issue or PR as related to a new feature.
Milestone
2.7.0

Comments

@yaacov
Copy link
Member

yaacov commented Apr 11, 2024

Ref: #1056

Part of PF5 migration

onCange, onClick signature in some elements changed in PF, make sure all our callbacks are named, and typed
@yaacov yaacov added the enhancement Categorizes issue or PR as related to a new feature. label Apr 11, 2024
@yaacov yaacov added this to the 2.7.0 milestone Apr 11, 2024
@sgratch
Copy link
Collaborator

sgratch commented Jun 5, 2024

Reference: https://www.patternfly.org/get-started/release-highlights/#event-handler-parameter-consistency-updates

sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Jun 10, 2024
@sgratch
Update to PF5 - part II - onClick event handler
071e6ea 
Reference: kubev2v#1098

Seems like onClick event handler parameters was changed in PF5 for few of the
components by enforcing the event handler as the first parameter (E.g. https://www.patternfly.org/components/chip/#chip
while in our code we are not passing the event
https://github.com/kubev2v/forklift-console-plugin/blob/686daff412d61c5e84c14f7b87fe2867038fc14b/packages/forklift-console-plugin/src/modules/Plans/views/create/components/ChipsToolbarProviders.tsx#L40).

For avoiding uncaught migration errors, this PR named and typed all callback appearances, when possible

Signed-off-by: Sharon Gratch <[email protected]>
@sgratch sgratch mentioned this issue Jun 10, 2024
Merged
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Jun 16, 2024
@sgratch
Update to PF5 - part II - onClick event handler
fdaa1e7 
Reference: kubev2v#1098

Seems like onClick event handler parameters was changed in PF5 for few of the
components by enforcing the event handler as the first parameter (E.g. https://www.patternfly.org/components/chip/#chip
while in our code we are not passing the event
https://github.com/kubev2v/forklift-console-plugin/blob/686daff412d61c5e84c14f7b87fe2867038fc14b/packages/forklift-console-plugin/src/modules/Plans/views/create/components/ChipsToolbarProviders.tsx#L40).

For avoiding uncaught migration errors, this PR named and typed all callback appearances, when possible

Signed-off-by: Sharon Gratch <[email protected]>
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Jun 17, 2024
@sgratch
Update to PF5 - part II - onClick event handler
00c76ce 
Reference: kubev2v#1098

Seems like onClick event handler parameters was changed in PF5 for few of the
components by enforcing the event handler as the first parameter (E.g. https://www.patternfly.org/components/chip/#chip
while in our code we are not passing the event
https://github.com/kubev2v/forklift-console-plugin/blob/686daff412d61c5e84c14f7b87fe2867038fc14b/packages/forklift-console-plugin/src/modules/Plans/views/create/components/ChipsToolbarProviders.tsx#L40).

For avoiding uncaught migration errors, this PR named and typed all callback appearances, when possible

Signed-off-by: Sharon Gratch <[email protected]>
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Jun 18, 2024
@sgratch
Update to PF5 - part II - onSelect, onToggle event handlers
c944633 
Reference: kubev2v#1098

For avoiding uncaught PF 4 -> PF 5 migration errors, this PR named and typed (i.e. (add type to function
signature) all onSelect, onToggle callbacks appearances which use parameters.

Signed-off-by: Sharon Gratch <[email protected]>
@sgratch sgratch mentioned this issue Jun 18, 2024
Merged
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Jun 18, 2024
@sgratch
Update to PF5 - part II - onClick event handler
dc9ee17 
Reference: kubev2v#1098

Seems like onClick event handler parameters was changed in PF5 for few of the
components by enforcing the event handler as the first parameter (E.g. https://www.patternfly.org/components/chip/#chip
while in our code we are not passing the event
https://github.com/kubev2v/forklift-console-plugin/blob/686daff412d61c5e84c14f7b87fe2867038fc14b/packages/forklift-console-plugin/src/modules/Plans/views/create/components/ChipsToolbarProviders.tsx#L40).

For avoiding uncaught migration errors, this PR named and typed all callback appearances, when possible

Signed-off-by: Sharon Gratch <[email protected]>
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Jun 18, 2024
@sgratch
Update to PF5 - part II - onClick event handler
5c6e273 
Reference: kubev2v#1098

Seems like onClick event handler parameters was changed in PF5 for few of the
components by enforcing the event handler as the first parameter (E.g. https://www.patternfly.org/components/chip/#chip
while in our code we are not passing the event
https://github.com/kubev2v/forklift-console-plugin/blob/686daff412d61c5e84c14f7b87fe2867038fc14b/packages/forklift-console-plugin/src/modules/Plans/views/create/components/ChipsToolbarProviders.tsx#L40).

For avoiding uncaught migration errors, this PR named and typed all callback appearances, when possible

Signed-off-by: Sharon Gratch <[email protected]>
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Jun 18, 2024
@sgratch
Update to PF5 - part II - onSelect, onToggle event handlers
5763175 
Reference: kubev2v#1098

For avoiding uncaught PF 4 -> PF 5 migration errors, this PR named and typed (i.e. (add type to function
signature) all onSelect, onToggle callbacks appearances which use parameters.

Signed-off-by: Sharon Gratch <[email protected]>
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Jul 3, 2024
@sgratch
Update to PF5 - part II - onSelect, onToggle event handlers
9009859 
Reference: kubev2v#1098

For avoiding uncaught PF 4 -> PF 5 migration errors, this PR named and typed (i.e. (add type to function
signature) all onSelect, onToggle callbacks appearances which use parameters.

Signed-off-by: Sharon Gratch <[email protected]>
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Jul 3, 2024
@sgratch
Update to PF5 - part II - onSelect, onToggle event handlers
2a8e1a3 
Reference: kubev2v#1098

For avoiding uncaught PF 4 -> PF 5 migration errors, this PR named and typed (i.e. (add type to function
signature) all onSelect, onToggle callbacks appearances which use parameters.

Signed-off-by: Sharon Gratch <[email protected]>
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Jul 4, 2024
@sgratch
Update to PF5 - part II - onSelect, onToggle event handlers
6776415 
Reference: kubev2v#1098

For avoiding uncaught PF 4 -> PF 5 migration errors, this PR named and typed (i.e. (add type to function
signature) all onSelect, onToggle callbacks appearances which use parameters.

Signed-off-by: Sharon Gratch <[email protected]>
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Jul 7, 2024
@sgratch
Update to PF5 - part II - onSelect, onToggle event handlers
590d459 
Reference: kubev2v#1098

For avoiding uncaught PF 4 -> PF 5 migration errors, this PR named and typed (i.e. (add type to function
signature) all onSelect, onToggle callbacks appearances which use parameters.

Signed-off-by: Sharon Gratch <[email protected]>
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Jul 15, 2024
@sgratch
Update to PF5 - part II - onChange event handler
1d0c35d 
Reference: kubev2v#1098

For avoiding uncaught PF 4 -> PF 5 migration errors, this PR named and typed (i.e. (add type to function signature) all onChange callback appearances which use parameters.

Signed-off-by: Sharon Gratch <[email protected]>
@sgratch sgratch mentioned this issue Jul 15, 2024
Merged
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Jul 16, 2024
@sgratch
Update to PF5 - part II - onChange event handler
5930a24 
Reference: kubev2v#1098

For avoiding uncaught PF 4 -> PF 5 migration errors, this PR named and typed (i.e. (add type to function signature) all onChange callback appearances which use parameters.

Signed-off-by: Sharon Gratch <[email protected]>
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Jul 16, 2024
@sgratch
Update to PF5 - part II - onChange event handler
29cb8ae 
Reference: kubev2v#1098

For avoiding uncaught PF 4 -> PF 5 migration errors, this PR named and typed (i.e. (add type to function signature) all onChange callback appearances which use parameters.

Signed-off-by: Sharon Gratch <[email protected]>
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Jul 17, 2024
@sgratch
Update to PF5 - part II - handle rest of event handlers
219d5ff 
Reference: kubev2v#1098

For avoiding uncaught PF 4 -> PF 5 migration errors, this PR named and typed
(i.e. (add type to function signature) the following callbacks appearances which use parameters:
 onFilter
 onTextInput
 onClear
 onDrop
 onInputKeyDown
 onSetPage
 onPerPageSelect
 onUserMinus
 onUserPlus
 onDataChange
 onTextChange

Signed-off-by: Sharon Gratch <[email protected]>
@sgratch sgratch mentioned this issue Jul 17, 2024
Merged
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Jul 18, 2024
@sgratch
Update to PF5 - part II - handle rest of event handlers
24c1c1f 
Reference: kubev2v#1098

For avoiding uncaught PF 4 -> PF 5 migration errors, this PR named and typed
(i.e. (add type to function signature) the following callbacks appearances which use parameters:
 onFilter
 onTextInput
 onClear
 onDrop
 onInputKeyDown
 onSetPage
 onPerPageSelect
 onUserMinus
 onUserPlus
 onDataChange
 onTextChange

Signed-off-by: Sharon Gratch <[email protected]>
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Jul 18, 2024
@sgratch
Update to PF5 - part II - handle rest of event handlers
c2c5baa 
Reference: kubev2v#1098

For avoiding uncaught PF 4 -> PF 5 migration errors, this PR named and typed
(i.e. (add type to function signature) the following callbacks appearances which use parameters:
 onFilter
 onTextInput
 onClear
 onDrop
 onInputKeyDown
 onSetPage
 onPerPageSelect
 onUserMinus
 onUserPlus
 onDataChange
 onTextChange

Signed-off-by: Sharon Gratch <[email protected]>
sgratch added a commit to sgratch/forklift-console-plugin that referenced this issue Jul 18, 2024
@sgratch
Update to PF5 - part II - handle rest of event handlers
60691e8 
Reference: kubev2v#1098

For avoiding uncaught PF 4 -> PF 5 migration errors, this PR named and typed
(i.e. (add type to function signature) the following callbacks appearances which use parameters:
 onFilter
 onTextInput
 onClear
 onDrop
 onInputKeyDown
 onSetPage
 onPerPageSelect
 onUserMinus
 onUserPlus
 onDataChange
 onTextChange

Signed-off-by: Sharon Gratch <[email protected]>
@sgratch
Copy link
Collaborator

sgratch commented Jul 22, 2024

@yaacov can we close this issue?

@yaacov
Copy link
Member Author

yaacov commented Jul 22, 2024

addressed by: #1287 #1269 #1221 #1208

@yaacov yaacov closed this as completed Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgratch sgratch

Labels
enhancement Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
2 participants
@yaacov @sgratch