fix: reconcile gateway client's node port #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kon3m
requested review from
narmidm,
bharath-avesha,
Rahul-D78,
gourishkb and
mridulgain
as code owners
11 tasks
kon3m
changed the title
|
Sure @kon3m, will review it and update you soon. |
narmidm
approved these changes
Apr 4, 2024
|
@narmidm a lot of e2e tests seem to fail after the recent update made to the pipeline. |
We've identified the root cause of the end-to-end failure; it was due to the last release. Please allow me half an hour to release a new image for automation, after which I will rerun and verify your PR. Apologies for the delayed response. |
|
@kon3m We have added a small fix for the PR pipeline failure. Please re-sync. |
Signed-off-by: kon3m <[email protected]>
kon3m
force-pushed
the
fix-ovpn-client-port-clean
branch
from
4301fec to
5c9b367
Compare
|
@mridulgain @narmidm i have just updated it, can you please trigger the e2e pipeline? |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #309
How Has This Been Tested?
Tested it manually using two single node kind clusters.
Checklist:
go fmtDoes this PR introduce a breaking change?