fix(): Reconciles port numbers in the ovpn client deployment #333

kon3m · 2024-02-15T14:24:23Z

Description

Fixes #309

How Has This Been Tested?

Tested it manually using two single node kind clusters, will write test cases soon using envtest and update the PR

Checklist:

Does this PR introduce a breaking change?

narmidm · 2024-02-22T11:28:04Z

one issue I notices the commits are unverified (No user is associated with the committer email). We require every contributor to certify that they are legally permitted to contribute to our project. A contributor expresses this by consciously signing their commits.

please follow this link. Let us know if you need any help.
https://github.com/kubeslice/worker-operator/blob/master/CONTRIBUTING.md#contributor-compliance-with-developer-certificate-of-origin-dco

kon3m · 2024-02-26T10:03:38Z

@narmidm the commits are verified now.

Rahul-D78

Apart from some small nits It's Looks great! Thanks for adding this and also for fixing the flaky test 👍

controllers/slicegateway/slicegateway.go

Rahul-D78

LGTM, thank you @kon3m

kon3m · 2024-02-27T05:29:39Z

Thanks for reviewing @Rahul-D78

narmidm · 2024-02-27T13:03:56Z

@kon3m Please mark the PR as ready for review when you are done. I will review it as soon as possible.

kon3m · 2024-02-28T11:29:40Z

@narmidm i have found an issue with this fix where in some cases distinct ports do not get assigned to the client deployments or to put in another way both the clients are connected to the same nodePort which should not happen. Thats the reason i have converted the PR to draft. Now i have updated the PR adding the fix for that as well, could you please review it?

narmidm · 2024-03-07T06:26:15Z

@kon3m , can you rebase with the latest master. it has some fixes of E2E pipeline. After That I will trigger the E2E again.

kon3m · 2024-03-07T07:22:09Z

@narmidm done, i have just rebased with master and pushed.

controllers/slicegateway/slicegateway.go

NishantSingh10 · 2024-03-29T13:06:06Z

report link 'https://kubeslice.github.io/e2e-allure-reports/Kind-worker-operator-2024-03-29T13:01:53-master-446/index.html'

narmidm · 2024-04-01T06:17:22Z

Urgent CRD changes are slated for release, and we will wait a couple of days for this PR to merge. @kon3m, you will likely need to sync your branch as well.

* feat(): api changes for no-net slice Signed-off-by: Mridul Gain <[email protected]> * feat(): block reconcilation of networking part Signed-off-by: Mridul Gain <[email protected]> * cluster reconciler changes for no net Signed-off-by: Mridul Gain <[email protected]> * skip workerslice health for no-net deployment Signed-off-by: Mridul Gain <[email protected]> * update slice reconciler for no-net Signed-off-by: Mridul Gain <[email protected]> * fix(): update cluster status to show network present or not Signed-off-by: Mridul Gain <[email protected]> * fix(): ITs & go version update Signed-off-by: Mridul Gain <[email protected]> * fix(): update apis tag Signed-off-by: Mridul Gain <[email protected]> --------- Signed-off-by: Mridul Gain <[email protected]>

Signed-off-by: kon3m <[email protected]>

kon3m · 2024-04-02T09:50:48Z

@narmidm @Rahul-D78 @bharath-avesha Closing this PR and will open a new/clean one as multiple authors and files got added which are not related to this PR. Will comment the new PR once i open it.

This is the newly opened PR : 368

kon3m · 2024-04-02T10:56:37Z

Opened a new clean PR

kon3m marked this pull request as ready for review February 22, 2024 09:40

kon3m requested review from narmidm, bharath-avesha, Rahul-D78, gourishkb and mridulgain as code owners February 22, 2024 09:40

kon3m mentioned this pull request Feb 22, 2024

Reconcile port numbers in ovpn client deployments #309

Closed

2 tasks

narmidm assigned kon3m Feb 22, 2024

narmidm added the ready-to-test label Feb 22, 2024

kon3m force-pushed the fix-ovpn-client-port branch 3 times, most recently from 4e8de96 to 8998f6e Compare February 26, 2024 09:08

Rahul-D78 reviewed Feb 27, 2024

View reviewed changes

controllers/slicegateway/slicegateway.go Outdated Show resolved Hide resolved

controllers/slicegateway/slicegateway.go Outdated Show resolved Hide resolved

Rahul-D78 approved these changes Feb 27, 2024

View reviewed changes

kon3m marked this pull request as draft February 27, 2024 10:35

narmidm marked this pull request as ready for review February 28, 2024 09:59

narmidm approved these changes Mar 1, 2024

View reviewed changes

kon3m force-pushed the fix-ovpn-client-port branch from 3984ab8 to ceddb76 Compare March 7, 2024 07:17

narmidm added ready-to-test and removed ready-to-test labels Mar 7, 2024

bharath-avesha reviewed Mar 8, 2024

View reviewed changes

controllers/slicegateway/slicegateway.go Show resolved Hide resolved

controllers/slicegateway/slicegateway.go Outdated Show resolved Hide resolved

kon3m force-pushed the fix-ovpn-client-port branch 2 times, most recently from 237dc66 to d72db75 Compare March 12, 2024 10:34

KRANTHI0918 added ready-to-test and removed ready-to-test labels Mar 31, 2024

KRANTHI0918 and others added 17 commits April 2, 2024 11:36

Update end-to-end-test.yaml

40e2f74

Update end-to-end-test.yaml

8295c56

Update end-to-end-test.yaml

839e077

Update end-to-end-test.yaml

b698b00

Update end-to-end-test.yaml

e12be65

Update end-to-end-test.yaml

992082b

Update end-to-end-test.yaml

1e6e022

Update end-to-end-test.yaml

0634437

Update end-to-end-test.yaml

5e56fc8

Update end-to-end-test.yaml

f7bbfec

fix: reconciles port numbers in ovpn client dep

2dd8b9a

Signed-off-by: kon3m <[email protected]>

removed package slices dependancy

25dc60d

Signed-off-by: kon3m <[email protected]>

rebased with master

3d9c819

Signed-off-by: kon3m <[email protected]>

fix: reconciles port numbers in ovpn client dep

886bddb

Signed-off-by: kon3m <[email protected]>

removed package slices dependancy

4ee06fa

Signed-off-by: kon3m <[email protected]>

rebased with master

3a92e0e

Signed-off-by: kon3m <[email protected]>

kon3m force-pushed the fix-ovpn-client-port branch from 3983917 to 5d7a82a Compare April 2, 2024 06:21

rebased with master and fixed conflicts

c613169

Signed-off-by: kon3m <[email protected]>

kon3m force-pushed the fix-ovpn-client-port branch from 5d7a82a to c613169 Compare April 2, 2024 06:26

kon3m closed this Apr 2, 2024

kon3m mentioned this pull request Apr 3, 2024

fix: reconcile gateway client's node port #368

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(): Reconciles port numbers in the ovpn client deployment #333

fix(): Reconciles port numbers in the ovpn client deployment #333

kon3m commented Feb 15, 2024

narmidm commented Feb 22, 2024 •

edited

Loading

kon3m commented Feb 26, 2024

Rahul-D78 left a comment •

edited

Loading

Rahul-D78 left a comment

kon3m commented Feb 27, 2024

narmidm commented Feb 27, 2024 •

edited

Loading

kon3m commented Feb 28, 2024

narmidm commented Mar 7, 2024

kon3m commented Mar 7, 2024

NishantSingh10 commented Mar 29, 2024

narmidm commented Apr 1, 2024

kon3m commented Apr 2, 2024 •

edited

Loading

kon3m commented Apr 2, 2024

fix(): Reconciles port numbers in the ovpn client deployment #333

fix(): Reconciles port numbers in the ovpn client deployment #333

Conversation

kon3m commented Feb 15, 2024

Description

How Has This Been Tested?

Checklist:

Does this PR introduce a breaking change?

narmidm commented Feb 22, 2024 • edited Loading

kon3m commented Feb 26, 2024

Rahul-D78 left a comment • edited Loading

Choose a reason for hiding this comment

Rahul-D78 left a comment

Choose a reason for hiding this comment

kon3m commented Feb 27, 2024

narmidm commented Feb 27, 2024 • edited Loading

kon3m commented Feb 28, 2024

narmidm commented Mar 7, 2024

kon3m commented Mar 7, 2024

NishantSingh10 commented Mar 29, 2024

narmidm commented Apr 1, 2024

kon3m commented Apr 2, 2024 • edited Loading

kon3m commented Apr 2, 2024

narmidm commented Feb 22, 2024 •

edited

Loading

Rahul-D78 left a comment •

edited

Loading

narmidm commented Feb 27, 2024 •

edited

Loading

kon3m commented Apr 2, 2024 •

edited

Loading