Replace eval by getattr

HISTORY.rst

@@ -9,6 +9,7 @@ tnefparse 1.4.0 (unreleased)
 - introduce using type annotations (jugmac00)
 - remove deprecated parseFile & raw_mapi functions
 - fix str representation for TNEF class (jugmac00)
+- prefer `getattr` over `eval` (eumiro)
 
 tnefparse 1.3.1 (2020-09-30)
 =============================

tests/test_cmdline.py

@@ -2,6 +2,7 @@
 import io
 import zipfile
 import json
+import logging
 import shutil
 import sys
 import tempfile
@@ -115,3 +116,29 @@ def test_print_overview(script_runner):
     assert "Attachments" in ret.stdout
     assert "Objects" in ret.stdout
     assert "Properties" in ret.stdout
+
+
+def test_cmdline_logging_info(caplog, capsys):
+    """Logging level set to INFO returns some INFO log messages"""
+    retv = tnefparse.cmdline.tnefparse(('-l', 'INFO', '-rb', 'tests/examples/rtf.tnef'))
+    assert not retv
+    stdout, _ = capsys.readouterr()
+    assert len(stdout) == 593
+    assert caplog.record_tuples == [
+        ('tnefparse', logging.INFO, 'Skipping checksum for performance'),
+    ]
+
+
+def test_cmdline_logging_warn(caplog, capsys):
+    """Logging level set to WARN returns no INFO log messages"""
+    retv = tnefparse.cmdline.tnefparse(('-l', 'WARN', '-rb', 'tests/examples/rtf.tnef'))
+    assert not retv
+    stdout, _ = capsys.readouterr()
+    assert len(stdout) == 593
+    assert caplog.record_tuples == []
+
+
+def test_cmdline_logging_illegal():
+    """Logging level set to ILLEGAL is illegal"""
+    with pytest.raises(SystemExit):
+        tnefparse.cmdline.tnefparse(('-l', 'ILLEGAL', '-rb', 'tests/examples/rtf.tnef'))

tnefparse/cmdline.py

@@ -50,18 +50,20 @@
          help="extract a json dump of the tnef contents")
 
 
-def tnefparse() -> None:
+def tnefparse(argv=None) -> None:
     "command-line script"
 
-    if len(sys.argv) == 1:
+    if argv is None:
+        argv = sys.argv[1:]
+
+    if not argv:
         parser.print_help()
         sys.exit(1)
 
-    args = parser.parse_args()
+    args = parser.parse_args(argv)
 
     if args.logging:
-        level = eval("logging." + args.logging)
-        logger.setLevel(level)
+        logger.setLevel(getattr(logging, args.logging))
 
     for tfp in args.file[0]:
         try: