Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace eval by getattr #84

Merged
merged 4 commits into from
Dec 13, 2020
Merged

Replace eval by getattr #84

merged 4 commits into from
Dec 13, 2020

Conversation

eumiro
Copy link
Contributor

@eumiro eumiro commented Nov 25, 2020

No need to use eval here.

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #84 (c4dd126) into master (f81554d) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   95.09%   95.33%   +0.23%     
==========================================
  Files           7        7              
  Lines        1284     1285       +1     
  Branches      115      116       +1     
==========================================
+ Hits         1221     1225       +4     
+ Misses         43       41       -2     
+ Partials       20       19       -1     
Impacted Files Coverage Δ
tnefparse/cmdline.py 100.00% <100.00%> (+3.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f81554d...c4dd126. Read the comment docs.

cmdline.py Outdated Show resolved Hide resolved
cmdline.py Outdated Show resolved Hide resolved
tnefparse/cmdline.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jugmac00 jugmac00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the deletion of the guard which checks for the argument length.

tnefparse/cmdline.py Outdated Show resolved Hide resolved
@jugmac00
Copy link
Collaborator

Please rebase/merge master once #93 is merged.

@eumiro eumiro requested a review from jugmac00 November 28, 2020 19:03
Copy link
Collaborator

@jugmac00 jugmac00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience, @eumiro - this PR is really special :-)

tnefparse/cmdline.py Outdated Show resolved Hide resolved
@jugmac00
Copy link
Collaborator

Ok, this looks good now!

Thanks for your patience.

There is one last thing...

Could you please add a docstring to both test_cmdline_logging_info and test_cmdline_logging_warn where you explain what the test is doing?

For reference, I like this short blog post on how to write good docstrings for tests:
https://jml.io/pages/test-docstrings.html

Thanks a lot!

@jugmac00 jugmac00 merged commit 2be9dfa into koodaamo:master Dec 13, 2020
@jugmac00
Copy link
Collaborator

The deed is done.

@eumiro eumiro deleted the eval-is-evil branch December 16, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants