De-duplicate attachment of OCI artifacts #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PSSECAUT-605, a user reports that there is some funny behavior that is likely due to us invoking oras attach *twice* here. There's no good reason to do it twice. Let's instead invoke it once, without specifying the distribution spec, and let oras choose for us.
|
/retest |
dirgim
requested review from
14rcole,
Josh-Everett,
hongweiliu17,
kasemAlem,
jencull and
chipspeak
kdudka
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Works as expected in my fork: kdudka/konflux-test-multicluster-global-hub#14 Thanks!
This was referenced Sep 19, 2024
|
/retest |
|
I've rebased and now all checks are passing @ralphbean |
|
Thanks @kasemAlem ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PSSECAUT-605, a user reports that there is some funny behavior that is likely due to us invoking oras attach twice here.
There's no good reason to do it twice. Let's instead invoke it once, without specifying the distribution spec, and let oras choose for us.