sast: Add sast-unicode-check task for testing #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanchuntao
force-pushed
the
sast-find-unicode-control
branch
from
643b08e to
279ec11
Compare
tkdchen
reviewed
Sep 12, 2024
hanchuntao
force-pushed
the
sast-find-unicode-control
branch
from
279ec11 to
55761cf
Compare
|
@tkdchen I want to test this task, do you know how to run the CI? thanks! |
hanchuntao
force-pushed
the
sast-find-unicode-control
branch
from
55761cf to
346ea59
Compare
updated, added OWNERS, thanks |
hanchuntao
force-pushed
the
sast-find-unicode-control
branch
2 times, most recently
from
aac253f to
859526e
Compare
kdudka
requested changes
Sep 12, 2024
task/sast-find-unicode-control/0.1/sast-find-unicode-control.yaml
Outdated
Show resolved
Hide resolved
task/sast-find-unicode-control/0.1/sast-find-unicode-control.yaml
Outdated
Show resolved
Hide resolved
task/sast-find-unicode-control/0.1/sast-find-unicode-control.yaml
Outdated
Show resolved
Hide resolved
task/sast-find-unicode-control/0.1/sast-find-unicode-control.yaml
Outdated
Show resolved
Hide resolved
|
@hanchuntao Please also include a reference to https://issues.redhat.com/browse/OSH-739 in the commit message. |
hanchuntao
force-pushed
the
sast-find-unicode-control
branch
7 times, most recently
from
082c7d0 to
8e0d599
Compare
kdudka
requested changes
Sep 13, 2024
There was a problem hiding this comment.
@hanchuntao Please rename the task to sast-unicode-check as stated in the summary of OSH-739.
hanchuntao
force-pushed
the
sast-find-unicode-control
branch
2 times, most recently
from
ec339ad to
c00c8c7
Compare
updated |
updated |
hanchuntao
force-pushed
the
sast-find-unicode-control
branch
from
c00c8c7 to
a835bd3
Compare
hanchuntao
changed the title
hanchuntao
force-pushed
the
sast-find-unicode-control
branch
2 times, most recently
from
db3e59e to
aa7eecb
Compare
5 tasks
kdudka
requested changes
Sep 19, 2024
There was a problem hiding this comment.
@hanchuntao Please close the review threads that have been resolved. I do not have permissions to do so.
hanchuntao
force-pushed
the
sast-find-unicode-control
branch
2 times, most recently
from
2ec25aa to
dd83120
Compare
|
@dheerajodha Because all of the checks passed, what should we do next? Can somebody with write access merge the code? |
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Oct 21, 2024
Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Oct 23, 2024
Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Oct 24, 2024
Before this change, the `sast-unicode-check` was failing with the
default parameters because the script was passing the whole list
of arguments as a single argument:
```
+ mapfile -t fuc_args
+ LANG=en_US.utf8
+ ./find-unicode-control/find_unicode_control.py '-p bidi -v -d -t' /var/workdir/source
+ FUC_EXIT_CODE=2
+ [[ 2 -ne 0 ]]
+ [[ 2 -ne 1 ]]
+ echo 'Failed to run find-unicode-control command'
Failed to run find-unicode-control command
+ cat raw_sast_unicode_check_out.log
usage: find_unicode_control.py [-h] [-p {all,bidi}] [-v] [-d] [-t] [-c CONFIG]
path [path ...]
find_unicode_control.py: error: argument -p/--nonprint: invalid choice: ' bidi -v -d -t' (choose from 'all', 'bidi')
+ note='Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
++ make_result_json -r ERROR -t 'Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
```
Fixes: konflux-ci#1401
Related: konflux-ci#1524
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Oct 24, 2024
Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524
|
@hanchuntao Are you sure you tested the changes before they were merged? I do not think this could work. See 82046fa for details. |
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Oct 24, 2024
Before this change, the `sast-unicode-check` was failing with the
default parameters because the script was passing the whole list
of arguments as a single argument:
```
+ mapfile -t fuc_args
+ LANG=en_US.utf8
+ ./find-unicode-control/find_unicode_control.py '-p bidi -v -d -t' /var/workdir/source
+ FUC_EXIT_CODE=2
+ [[ 2 -ne 0 ]]
+ [[ 2 -ne 1 ]]
+ echo 'Failed to run find-unicode-control command'
Failed to run find-unicode-control command
+ cat raw_sast_unicode_check_out.log
usage: find_unicode_control.py [-h] [-p {all,bidi}] [-v] [-d] [-t] [-c CONFIG]
path [path ...]
find_unicode_control.py: error: argument -p/--nonprint: invalid choice: ' bidi -v -d -t' (choose from 'all', 'bidi')
+ note='Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
++ make_result_json -r ERROR -t 'Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
```
Fixes: konflux-ci#1401
Related: konflux-ci#1524
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Oct 24, 2024
Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524
I tested all of the changes. I don't know what happened, let me check it first, thanks After rerunning this task in my local environment, yes the issue exists. I have filed a new PR to fix this issue: #1535 |
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Nov 6, 2024
Before this change, the `sast-unicode-check` was failing with the
default parameters because the script was passing the whole list
of arguments as a single argument:
```
+ mapfile -t fuc_args
+ LANG=en_US.utf8
+ ./find-unicode-control/find_unicode_control.py '-p bidi -v -d -t' /var/workdir/source
+ FUC_EXIT_CODE=2
+ [[ 2 -ne 0 ]]
+ [[ 2 -ne 1 ]]
+ echo 'Failed to run find-unicode-control command'
Failed to run find-unicode-control command
+ cat raw_sast_unicode_check_out.log
usage: find_unicode_control.py [-h] [-p {all,bidi}] [-v] [-d] [-t] [-c CONFIG]
path [path ...]
find_unicode_control.py: error: argument -p/--nonprint: invalid choice: ' bidi -v -d -t' (choose from 'all', 'bidi')
+ note='Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
++ make_result_json -r ERROR -t 'Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
```
Fixes: konflux-ci#1401
Related: konflux-ci#1524
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Nov 6, 2024
Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Nov 6, 2024
Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Nov 11, 2024
Before this change, the `sast-unicode-check` was failing with the
default parameters because the script was passing the whole list
of arguments as a single argument:
```
+ mapfile -t fuc_args
+ LANG=en_US.utf8
+ ./find-unicode-control/find_unicode_control.py '-p bidi -v -d -t' /var/workdir/source
+ FUC_EXIT_CODE=2
+ [[ 2 -ne 0 ]]
+ [[ 2 -ne 1 ]]
+ echo 'Failed to run find-unicode-control command'
Failed to run find-unicode-control command
+ cat raw_sast_unicode_check_out.log
usage: find_unicode_control.py [-h] [-p {all,bidi}] [-v] [-d] [-t] [-c CONFIG]
path [path ...]
find_unicode_control.py: error: argument -p/--nonprint: invalid choice: ' bidi -v -d -t' (choose from 'all', 'bidi')
+ note='Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
++ make_result_json -r ERROR -t 'Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
```
Fixes: konflux-ci#1401
Related: konflux-ci#1524
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Nov 11, 2024
Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Nov 13, 2024
Before this change, the `sast-unicode-check` was failing with the
default parameters because the script was passing the whole list
of arguments as a single argument:
```
+ mapfile -t fuc_args
+ LANG=en_US.utf8
+ ./find-unicode-control/find_unicode_control.py '-p bidi -v -d -t' /var/workdir/source
+ FUC_EXIT_CODE=2
+ [[ 2 -ne 0 ]]
+ [[ 2 -ne 1 ]]
+ echo 'Failed to run find-unicode-control command'
Failed to run find-unicode-control command
+ cat raw_sast_unicode_check_out.log
usage: find_unicode_control.py [-h] [-p {all,bidi}] [-v] [-d] [-t] [-c CONFIG]
path [path ...]
find_unicode_control.py: error: argument -p/--nonprint: invalid choice: ' bidi -v -d -t' (choose from 'all', 'bidi')
+ note='Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
++ make_result_json -r ERROR -t 'Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
```
Fixes: konflux-ci#1401
Related: konflux-ci#1524
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Nov 13, 2024
Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Nov 18, 2024
Before this change, the `sast-unicode-check` was failing with the
default parameters because the script was passing the whole list
of arguments as a single argument:
```
+ mapfile -t fuc_args
+ LANG=en_US.utf8
+ ./find-unicode-control/find_unicode_control.py '-p bidi -v -d -t' /var/workdir/source
+ FUC_EXIT_CODE=2
+ [[ 2 -ne 0 ]]
+ [[ 2 -ne 1 ]]
+ echo 'Failed to run find-unicode-control command'
Failed to run find-unicode-control command
+ cat raw_sast_unicode_check_out.log
usage: find_unicode_control.py [-h] [-p {all,bidi}] [-v] [-d] [-t] [-c CONFIG]
path [path ...]
find_unicode_control.py: error: argument -p/--nonprint: invalid choice: ' bidi -v -d -t' (choose from 'all', 'bidi')
+ note='Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
++ make_result_json -r ERROR -t 'Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
```
Fixes: konflux-ci#1401
Related: konflux-ci#1524
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Nov 18, 2024
Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Nov 20, 2024
Before this change, the `sast-unicode-check` was failing with the
default parameters because the script was passing the whole list
of arguments as a single argument:
```
+ mapfile -t fuc_args
+ LANG=en_US.utf8
+ ./find-unicode-control/find_unicode_control.py '-p bidi -v -d -t' /var/workdir/source
+ FUC_EXIT_CODE=2
+ [[ 2 -ne 0 ]]
+ [[ 2 -ne 1 ]]
+ echo 'Failed to run find-unicode-control command'
Failed to run find-unicode-control command
+ cat raw_sast_unicode_check_out.log
usage: find_unicode_control.py [-h] [-p {all,bidi}] [-v] [-d] [-t] [-c CONFIG]
path [path ...]
find_unicode_control.py: error: argument -p/--nonprint: invalid choice: ' bidi -v -d -t' (choose from 'all', 'bidi')
+ note='Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
++ make_result_json -r ERROR -t 'Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
```
Fixes: konflux-ci#1401
Related: konflux-ci#1524
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Nov 20, 2024
Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Nov 20, 2024
Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Nov 25, 2024
Before this change, the `sast-unicode-check` was failing with the
default parameters because the script was passing the whole list
of arguments as a single argument:
```
+ mapfile -t fuc_args
+ LANG=en_US.utf8
+ ./find-unicode-control/find_unicode_control.py '-p bidi -v -d -t' /var/workdir/source
+ FUC_EXIT_CODE=2
+ [[ 2 -ne 0 ]]
+ [[ 2 -ne 1 ]]
+ echo 'Failed to run find-unicode-control command'
Failed to run find-unicode-control command
+ cat raw_sast_unicode_check_out.log
usage: find_unicode_control.py [-h] [-p {all,bidi}] [-v] [-d] [-t] [-c CONFIG]
path [path ...]
find_unicode_control.py: error: argument -p/--nonprint: invalid choice: ' bidi -v -d -t' (choose from 'all', 'bidi')
+ note='Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
++ make_result_json -r ERROR -t 'Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
```
Fixes: konflux-ci#1401
Related: konflux-ci#1524
kdudka
added a commit
to kdudka/build-definitions
that referenced
this pull request
Nov 25, 2024
Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
Before this change, the `sast-unicode-check` was failing with the
default parameters because the script was passing the whole list
of arguments as a single argument:
```
+ mapfile -t fuc_args
+ LANG=en_US.utf8
+ ./find-unicode-control/find_unicode_control.py '-p bidi -v -d -t' /var/workdir/source
+ FUC_EXIT_CODE=2
+ [[ 2 -ne 0 ]]
+ [[ 2 -ne 1 ]]
+ echo 'Failed to run find-unicode-control command'
Failed to run find-unicode-control command
+ cat raw_sast_unicode_check_out.log
usage: find_unicode_control.py [-h] [-p {all,bidi}] [-v] [-d] [-t] [-c CONFIG]
path [path ...]
find_unicode_control.py: error: argument -p/--nonprint: invalid choice: ' bidi -v -d -t' (choose from 'all', 'bidi')
+ note='Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
++ make_result_json -r ERROR -t 'Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.'
```
Fixes: #1401
Related: #1524
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: #1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: #1524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.