hardware key runners #1977
hardware key runners #1977
Conversation
James-Pickett
commented
Dec 4, 2024
•
James-Pickett
commented
- adds secure enclave create key command to desktop user server, client, and root desktop runner
- adds a "runner" style struct to handle initializing keys for both tpm and secure enclave that is added to the rungroup in main launcher command, this allows for initializing (and retrying failures) of tpm and secure enclave keys
- signing with secure enclave will come in a follow on PR
| @@ -0,0 +1,241 @@ | |||
| package tpmrunner | |||
There was a problem hiding this comment.
Would you add a quick diagram/writeup in the docs/architecture folder for this? Since this work traverses both root and user launcher, and the implementation differs between darwin/other OSes (plus the keys are pretty important) I think it's worth documenting how the different pieces fit together. Doesn't have to be in this PR!
There was a problem hiding this comment.
I'm a little curious about this as well. I understand why we need to move the secure enclave signing. But I'm much less sure what's happening with the TPM
There was a problem hiding this comment.
@RebeccaMahany , I will write up some docs for this PR
@directionless there are 2 reasons I went ahead and made the tpm a "runner" style like secure enclave.
-
We do see errors pop up with TPM operations that I can't reproduce. I'm hoping that these have something to do with the TPM not being ready or unavailable for some reason, taking this route we'll keep trying in the background hoping it becomes available.
-
It felt cleaner to have both hardware signature mechanisms operate in the same way. Understanding that no kind of hardware signing can be expected to be available immediately after start up.
| } | ||
|
|
||
| k, err := tpm.New(priData, pubData) | ||
| // SetHardwareKeysRunner creates a tpm runner and sets it as the agent hardware key as it also implements the keyInt/cyrpto.Signer interface. |
There was a problem hiding this comment.
Naming question... If this returns a runner, why is it called Set?
There was a problem hiding this comment.
The runner also implements keyInt & crypto.Signer and gets set as the hardware key, maybe CreateSetHardwareKeysRunner? Or possible different functions for create and set?
| @@ -0,0 +1,241 @@ | |||
| package tpmrunner | |||
There was a problem hiding this comment.
I'm a little curious about this as well. I understand why we need to move the secure enclave signing. But I'm much less sure what's happening with the TPM
