You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many of our rungroup actors contain interrupt chan struct{} and interrupted bool fields within their structs. We use the interrupted bool to prevent accidentally running shutdown routines twice; rungroup actors should be able to have their shutdown functions called multiple times.
However, interrupted bool can cause data races in tests. We should update to use atomic.Bool in all rungroup actors that have an interrupt and interrupted field.
Many of our rungroup actors contain
interrupt chan struct{}
andinterrupted bool
fields within their structs. We use theinterrupted
bool to prevent accidentally running shutdown routines twice; rungroup actors should be able to have their shutdown functions called multiple times.However,
interrupted bool
can cause data races in tests. We should update to useatomic.Bool
in all rungroup actors that have aninterrupt
andinterrupted
field.We can use James's work in #1977 as an example.
The text was updated successfully, but these errors were encountered: