Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump DNSControl to v4.1.0 #103

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Bump DNSControl to v4.1.0 #103

wants to merge 1 commit into from

Conversation

koenrh
Copy link
Owner

@koenrh koenrh commented May 29, 2023

No description provided.

@Firefishy
Copy link
Contributor

Firefishy commented Jun 1, 2023 •
edited
Loading

Awesome to see moving to the upstream container image!
It means Dependabot would be able to suggest updates in future.

@Firefishy
Copy link
Contributor

Upstream is now available via GitHub Container Registry eg: ghcr.io/stackexchange/dnscontrol:4.1.1

adamus1red
adamus1red suggested changes Aug 6, 2023
View reviewed changes
Dockerfile
echo "$DNSCONTROL_CHECKSUM dnscontrol" | sha256sum -c - && \
chmod +x dnscontrol && \
mv dnscontrol /usr/local/bin/dnscontrol

RUN ["dnscontrol", "version"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stackexchange/dnscontrol doesn't come with bash which is required for entrypoint.sh. In my testing changing this run line to include an apk add for bash fixes this.

RUN dnscontrol version && \
    apk add --no-cache bash

@chrisbrownie
Copy link

@koenrh any indication on when this might land?

@dan-is-not-the-man
Copy link

Any news on this?

[INFO: Old diff algorithm in use. Please test `dnscontrol --diff2 preview` (or push) as it will be the default in releases after 2023-05-07. See https://github.com/StackExchange/dnscontrol/issues/2262]

@jauderho
Copy link

jauderho commented May 24, 2024 •
edited
Loading

I did not want to wait so I forked this repo to https://github.com/jauderho/dnscontrol-action

Here's the difference (note the different container image): main...jauderho:dnscontrol-action:main

Dockerfile is located here: https://github.com/jauderho/dockerfiles/blob/main/dnscontrol/Dockerfile

This will now always use the latest version of dnscontrol. Carefully review before any usage. YMMV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamus1red adamus1red adamus1red requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@koenrh @Firefishy @chrisbrownie @dan-is-not-the-man @jauderho @adamus1red