Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DNSControl to v4.1.0 #103

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM alpine:3.17.2@sha256:69665d02cb32192e52e07644d76bc6f25abeb5410edc1c7a81a10ba3f0efb90a
FROM stackexchange/dnscontrol:4.1.0@sha256:c0aa9022c631ad1390fc3aaae0ef7af2d429b66a0626d44f2b9fc90f38ba54e2

LABEL repository="https://github.com/koenrh/dnscontrol-action"
LABEL maintainer="Koen Rouwhorst <[email protected]>"
Expand All @@ -8,18 +8,6 @@ LABEL "com.github.actions.description"="Deploy your DNS configuration to multipl
LABEL "com.github.actions.icon"="cloud"
LABEL "com.github.actions.color"="yellow"

ENV DNSCONTROL_VERSION="3.31.4"
ENV DNSCONTROL_CHECKSUM="054d236531df2674c9286279596f88f02c1cf7b1448dc5f643f1a1dbe705fe8d"

RUN apk -U --no-cache upgrade && \
apk add --no-cache bash ca-certificates curl libc6-compat

RUN curl -sL "https://github.com/StackExchange/dnscontrol/releases/download/v$DNSCONTROL_VERSION/dnscontrol-Linux" \
-o dnscontrol && \
echo "$DNSCONTROL_CHECKSUM dnscontrol" | sha256sum -c - && \
chmod +x dnscontrol && \
mv dnscontrol /usr/local/bin/dnscontrol

RUN ["dnscontrol", "version"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stackexchange/dnscontrol doesn't come with bash which is required for entrypoint.sh. In my testing changing this run line to include an apk add for bash fixes this.

RUN dnscontrol version && \
    apk add --no-cache bash


COPY README.md entrypoint.sh bin/filter-preview-output.sh /
Expand Down