Kiwix desktop jammy appimage #771
Conversation
veloman-yunkan
changed the title
|
So we need to introduce a |
|
@veloman-yunkan Great but I don't know how/what to answer to you. We probably need to move the whole linux compilation ci/cd on jammy. |
@kelson42 Then I believe that such a transition shouldn't be done as part of this PR. Rather a separate ticket must be opened and the pros and cons of the proposed upgrade should be discussed there in a broader scope. |
|
@veloman-yunkan So what would be the solution for |
Maybe we can release only |
As this stage, I believe this could be a temporary solution indeed. |
veloman-yunkan
force-pushed
the
kiwix-desktop_jammy_appimage
branch
2 times, most recently
from
bab1edb
to
61f7d3f
Compare
veloman-yunkan
changed the title
|
The PR is mostly ready. The most recent CI run generated an appimage built under jammy (https://tmp.kiwix.org/ci/dev_preview/kiwix-desktop_jammy_appimage/kiwix-desktop_x86_64_2024-11-25.appimage) that is devoid of the issue reported in kiwix/kiwix-desktop#1219. The failure of the two CI runs under manylinux seems to be because of the change of the builder docker image tag from |
|
FYI, regarding the flatpak version of kiwix-desktop - it (https://tmp.kiwix.org/ci/dev_preview/kiwix-desktop_jammy_appimage/org.kiwix.desktop.2024-11-25.flatpak which was built under focal) works fine since a newer version of Qt is used in Flatpak. |
I cannot find where the manylinux version of the docker image is hosted. https://ghcr.io/kiwix/kiwix-build_ci_focal works, https://ghcr.io/kiwix/kiwix-build_ci_manylinux doesn't. |
kelson42
force-pushed
the
kiwix-desktop_jammy_appimage
branch
from
61f7d3f
to
d424a4e
Compare
Maybe installing the |
@benoit74 @rgaudin Do you have an idea why the CI fails? The packages |
|
@kelson42, again, don't look at the Upload failure logs output. The problem is always in previous steps. In this one, it's in the checkout one: |
There was a problem hiding this comment.
Looks good to me and could be considered ready to merge once:
- CI is fixed, see Update and pin Manylinux CI
FROMimage container-images#265 - Docker image dependencies are pinned (again)
- @rgaudin has approved on his side
veloman-yunkan
force-pushed
the
kiwix-desktop_jammy_appimage
branch
from
d424a4e
to
b7a619f
Compare
This reverts commit dee57f1.
- Switched from linuxdeployqt to (linuxdeploy + linuxdeploy-plugin-qt) - Eliminated custom creation of the AppDir & most manual copying of some stuff into it (trusting linuxdeploy to do everything needed for the correct operation of the appimage). Note, however, that nss/ libs are no longer bundled with the appimage (libthai.so is forcefully bundled via a special option to linuxdeploy).
Next we are going to have some CI/CD jobs running on jammy instead of focal that's why the build platform for Linux jobs has to be made explicit.
veloman-yunkan
force-pushed
the
kiwix-desktop_jammy_appimage
branch
from
b7a619f
to
ff2ade2
Compare
Fixes kiwix/kiwix-desktop#1219
Depends on kiwix/container-images#264
A working appimage was created using the updated
scripts/create_kiwix-desktop_appImage.shin a docker container build using the following Dockerfilekiwix-build_ci/jammy_builder.dockerfileintroduced by kiwix/container-images#264).