Update and pin Manylinux CI FROM image
#265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelson42
changed the title
FROM image
|
@rgaudin I have no idea why the |
|
it's all green isn't it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix CI for kiwix/kiwix-build#771
Because the
FROMof the Manylinux was not pinned, latest rebuild has made ouranylinux_builder.dockerfileobselete in a way which was only detectable later at run (bad$ENVvariable).This is exactly to avoid this kind of hassle that all dependencies should always be fixed/pinned!
I don't understand why we have all these tools installed outside the system paths, which then generate the need of a customized
$PATH. But I have decided to be conservative and just keep this approach and fix things using the current approach.