#4083 fixed external link warning when user wants to make a donation

app/src/androidTest/java/org/kiwix/kiwixmobile/main/TopLevelDestinationTest.kt

@@ -123,7 +123,6 @@ class TopLevelDestinationTest : BaseActivityTest() {
       clickSettingsOnSideNav(SettingsRobot::assertMenuSettingsDisplayed)
       clickHelpOnSideNav(HelpRobot::assertToolbarDisplayed)
       clickSupportKiwixOnSideNav()
-      assertExternalLinkDialogDisplayed()
       pressBack()
     }
     LeakAssertions.assertNoLeaks()

core/src/main/java/org/kiwix/kiwixmobile/core/main/CoreMainActivity.kt

@@ -280,7 +280,7 @@ abstract class CoreMainActivity : BaseActivity(), WebViewProvider {
   }
 
   fun openSupportKiwixExternalLink() {
-    externalLinkOpener.openExternalUrl(KIWIX_SUPPORT_URL.toUri().browserIntent())
+    externalLinkOpener.openExternalUrl(KIWIX_SUPPORT_URL.toUri().browserIntent(), false)
   }
 
   private fun handleBackPressed() {

core/src/main/java/org/kiwix/kiwixmobile/core/main/CoreReaderFragment.kt

@@ -1677,6 +1677,10 @@ abstract class CoreReaderFragment :
     externalLinkOpener?.openExternalUrl(intent)
   }
 
+  fun openExternalUrl(intent: Intent, showExternalLinkPopup: Boolean) {
+    externalLinkOpener?.openExternalUrl(intent, showExternalLinkPopup)
+  }
+
   override fun showSaveOrOpenUnsupportedFilesDialog(url: String, documentType: String?) {
     unsupportedMimeTypeHandler?.showSaveOrOpenUnsupportedFilesDialog(
       url,

core/src/main/java/org/kiwix/kiwixmobile/core/utils/ExternalLinkOpener.kt

@@ -34,10 +34,15 @@ class ExternalLinkOpener @Inject constructor(
 ) {
 
   fun openExternalUrl(intent: Intent) {
+    // Show popup with warning that this url is external and could lead to additional costs
+    // or may event not work when the user is offline.
+    openExternalUrl(intent, sharedPreferenceUtil.prefExternalLinkPopup)
+  }
+
+  // Overload for ignoring sharedPreferenceUtil.prefExternalLinkPopup
+  fun openExternalUrl(intent: Intent, showExternalLinkPopup: Boolean) {
     if (intent.resolveActivity(activity.packageManager) != null) {
-      // Show popup with warning that this url is external and could lead to additional costs
-      // or may event not work when the user is offline.
-      if (sharedPreferenceUtil.prefExternalLinkPopup) {
+      if (showExternalLinkPopup) {
         requestOpenLink(intent)
       } else {
         openLink(intent)

custom/src/main/java/org/kiwix/kiwixmobile/custom/main/CustomMainActivity.kt

@@ -186,7 +186,7 @@ class CustomMainActivity : CoreMainActivity() {
   private fun openExternalUrl(url: String) {
     // check if the provided url is not empty.
     if (url.isNotEmpty()) {
-      externalLinkOpener.openExternalUrl(url.toUri().browserIntent())
+      externalLinkOpener.openExternalUrl(url.toUri().browserIntent(), false)
     }
   }
 

custom/src/main/java/org/kiwix/kiwixmobile/custom/main/CustomReaderFragment.kt

@@ -348,7 +348,7 @@ class CustomReaderFragment : CoreReaderFragment() {
 
   override fun openKiwixSupportUrl() {
     if (BuildConfig.SUPPORT_URL.isNotEmpty()) {
-      openExternalUrl(BuildConfig.SUPPORT_URL.toUri().browserIntent())
+      openExternalUrl(BuildConfig.SUPPORT_URL.toUri().browserIntent(), false)
     }
   }