#4083 fixed external link warning when user wants to make a donation #4133
Conversation
There was a problem hiding this comment.
@viditpawar0 We have the DonationPopup functionality as well which we have recently added, which shows on the reader screen. So when the user clicks on the "Make a donation" button this method calls
According to your existing code, it will work fine with the Kiwix app, but for custom apps, we have overrided this method in CustomReaderFragment to make custom behavior according to configuration. So we have to make the changes there as well so that when while user clicks on the donation button in custom apps this popup will not show.
Apart from these changes: The test cases are falling due to this change specially topLevelDestinationTest so can you please fix that?
|
Sure, I'll do that. |
…tion for custom apps
…aderFragment.kt
|
All the requested changes have been done. Summary: -
|
There was a problem hiding this comment.
@viditpawar0 Thanks for making the changes. Please see comments.
| @@ -123,7 +123,6 @@ class TopLevelDestinationTest : BaseActivityTest() { | |||
| clickSettingsOnSideNav(SettingsRobot::assertMenuSettingsDisplayed) | |||
| clickHelpOnSideNav(HelpRobot::assertToolbarDisplayed) | |||
| clickSupportKiwixOnSideNav() | |||
| assertExternalLinkDialogDisplayed() | |||
There was a problem hiding this comment.
The same we are using in the GetContentShortcutTest so please make the changes there as well.
| @@ -186,7 +186,7 @@ class CustomMainActivity : CoreMainActivity() { | |||
| private fun openExternalUrl(url: String) { | |||
| // check if the provided url is not empty. | |||
| if (url.isNotEmpty()) { | |||
| externalLinkOpener.openExternalUrl(url.toUri().browserIntent()) | |||
| externalLinkOpener.openExternalUrl(url.toUri().browserIntent(), false) | |||
There was a problem hiding this comment.
@viditpawar0 This code is used from two places, so your code works fine when someone wants to make a donation, but it does not show the external link popup if there is about_app URL is configured. It should show the external link popup for the about_app URL.
screen-20241212-112625.mp4
Fixes #4083
Fixed external link warning when user wants to make a donation