-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: enhance test coverage for keptn-cert-manager #3143
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3143 +/- ##
===========================================
- Coverage 85.33% 75.16% -10.17%
===========================================
Files 167 76 -91
Lines 7412 4232 -3180
===========================================
- Hits 6325 3181 -3144
- Misses 799 820 +21
+ Partials 288 231 -57 see 106 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
@YashPimple can you please adapt your PR according to @RealAnna requests? |
@odubajDT Yes currently working on it and will make the commits in couples of days |
Quality Gate passedIssues Measures |
Hi @YashPimple any updates on this? |
@odubajDT i have prior only made the suggested changes in the above force commit |
@YashPimple please see this |
@YashPimple ny updates on this please ? |
Yes will update the required changes by the EOD and will keep you updated on it. |
@odubajDT I have updated the above test function name as suggested. |
Signed-off-by: Yash Pimple <[email protected]>
Signed-off-by: Yash Pimple <[email protected]>
Quality Gate passedIssues Measures |
Description
This PR aims to improve the test coverage of Keptn-cert-manager components
Fixes #3038
Coverage Summary: