-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce tests for lifecycle-operator bugs #3121
Comments
Hi @odubajDT , I can try to solve this issue. Can you assign it to me? Thank you! |
Hi @SohamRatnaparkhi are you actively working on this issue? Since you have this issue assigned for aprox. 10 days, we usually unassign asignees from their issues if there is no activity to not block other potential contributors from starting to tackle them. Thanks for the update! |
Hey @odubajDT Once again, I'm really sorry :) |
No worries, thank you very much for your answer! :) If you have time in the future, we would be happy if you reach out to us for potentially another issue! |
Hey I can take on this one If no one is working |
Hi @Bharadwajshivam28 are you actively working on this issue? Since you have this issue assigned for aprox. 3 weeks, we usually unassign asignees from their issues if there is no activity to not block other potential contributors from starting to tackle them. Thanks for the update! |
Due to inactivity, unassigning @Bharadwajshivam28 from this issue. Feel free to request a different issue! |
Hi @odubajDT I would like to work on the above issue |
@YashPimple I assigned it to you but please before you start, there is a small change required in the PR you have opened #3143. try to please finish this one first before you start with a new one |
Hi! @odubajDT, I would like to take up this issue. Since the non-blocking mode does not introduce any errors in the controller, we can write a unit test with a mock handler that does not return any errors when the KeptnAppVersionStatus resembles the manifest in the docs Am I correctly understanding the task here? |
@Jay179-sudo sure thing, I assigned it to you |
This issue will be unassigned in 1 week if no further activity is seen. |
un-assigning, due to inactivity |
This issue has been automatically marked as stale because it has not had recent activity. It will be |
Hi @odubajDT , is this issue still open to contributions? If yes, I would love to work on it! |
Recently multiple small bugs were found and fixed as part of this PR.
The places are:
Introduce unit tests to cover the affected functionality
The text was updated successfully, but these errors were encountered: