Remove unused code from starkware_utils

crates/starknet-os/src/starkware_utils/commitment_tree/binary_fact_tree_node.rs

@@ -174,20 +174,7 @@ where
         ffc: &'a mut FactFetchingContext<S, H>,
         indices: &'a [TreeIndex],
         facts: &'a mut Option<BinaryFactDict>,
-    ) -> impl std::future::Future<Output = Result<HashMap<TreeIndex, LF>, TreeError>> + Send {
-        async move {
-            if indices.is_empty() {
-                return Ok(HashMap::default());
-            }
-
-            if self.is_leaf() {
-                return self._get_leaf(ffc, indices).await;
-            }
-
-            self._get_binary_node_leaves(ffc, indices, facts).await
-        }
-        .boxed()
-    }
+    ) -> impl std::future::Future<Output = Result<HashMap<TreeIndex, LF>, TreeError>> + Send;
 
     /// Returns the values of the leaves whose indices are given.
     fn _get_binary_node_leaves<'a>(

crates/starknet-os/src/starkware_utils/commitment_tree/calculation.rs

@@ -50,15 +50,6 @@ pub trait Calculation<T, LF> {
     /// (using their hash as the key).
     fn calculate(&self, dependency_results: Vec<Box<dyn Any>>, fact_nodes: &mut NodeFactDict<LF>) -> T;
 
-    /// Same as calculate(), but return the facts.
-
-    fn calculate_new_fact_nodes(&self, dependency_results: Vec<Box<dyn Any>>) -> (T, NodeFactDict<LF>) {
-        let mut fact_nodes = NodeFactDict::default();
-        let result = self.calculate(dependency_results, &mut fact_nodes);
-
-        (result, fact_nodes)
-    }
-
     /// Produces the result of this calculation.
     ///
     /// Recursively calculates the result of the dependency calculations.
@@ -74,17 +65,6 @@ pub trait Calculation<T, LF> {
 
         self.calculate(dependency_results, fact_nodes)
     }
-
-    /// Produces the result of this calculation. Returns the result and a dict containing generated
-    /// facts.
-    ///
-    /// Recursively calculates the result of the dependency calculations.
-    fn full_calculate_new_fact_nodes(&self) -> (T, NodeFactDict<LF>) {
-        let mut fact_nodes = NodeFactDict::default();
-        let result = self.full_calculate(&mut fact_nodes);
-
-        (result, fact_nodes)
-    }
 }
 
 pub(crate) struct DependencyWrapper<D, T, LF>

crates/starknet-os/src/starkware_utils/commitment_tree/patricia_tree/nodes.rs

@@ -11,51 +11,6 @@ use crate::storage::storage::{DbObject, Fact, HashFunctionType, Storage, HASH_BY
 
 const PATRICIA_NODE_PREFIX: &[u8] = "patricia_node".as_bytes();
 
-/// Represents the root of an empty (all leaves are 0) full binary tree.
-pub struct EmptyNodeFact;
-
-impl EmptyNodeFact {
-    const PREIMAGE_LENGTH: usize = 0;
-}
-
-impl<S, H> InnerNodeFact<S, H> for EmptyNodeFact
-where
-    H: HashFunctionType,
-    S: Storage,
-{
-    fn to_tuple(&self) -> Vec<BigUint> {
-        vec![]
-    }
-}
-
-impl<S, H> Fact<S, H> for EmptyNodeFact
-where
-    H: HashFunctionType,
-    S: Storage,
-{
-    fn hash(&self) -> Hash {
-        Hash::empty()
-    }
-}
-
-impl DbObject for EmptyNodeFact {}
-
-impl SerializationPrefix for EmptyNodeFact {
-    fn prefix() -> Vec<u8> {
-        PATRICIA_NODE_PREFIX.to_vec()
-    }
-}
-
-impl Serializable for EmptyNodeFact {
-    fn serialize(&self) -> Result<Vec<u8>, SerializeError> {
-        Ok("".as_bytes().to_vec())
-    }
-
-    fn deserialize(_data: &[u8]) -> Result<Self, DeserializeError> {
-        Ok(Self {})
-    }
-}
-
 #[derive(thiserror::Error, Debug)]
 pub enum BinaryNodeError {
     #[allow(unused)]
@@ -240,7 +195,6 @@ fn hash_edge<H: HashFunctionType>(bottom: &[u8], path: NodePath, length: Length)
 }
 
 pub enum PatriciaNodeFact {
-    Empty(EmptyNodeFact),
     Binary(BinaryNodeFact),
     Edge(EdgeNodeFact),
 }
@@ -254,15 +208,13 @@ impl SerializationPrefix for PatriciaNodeFact {
 impl Serializable for PatriciaNodeFact {
     fn serialize(&self) -> Result<Vec<u8>, SerializeError> {
         match self {
-            Self::Empty(empty) => empty.serialize(),
             Self::Binary(binary) => binary.serialize(),
             Self::Edge(edge) => edge.serialize(),
         }
     }
 
     fn deserialize(data: &[u8]) -> Result<Self, DeserializeError> {
         let node = match data.len() {
-            EmptyNodeFact::PREIMAGE_LENGTH => Self::Empty(EmptyNodeFact::deserialize(data)?),
             BinaryNodeFact::PREIMAGE_LENGTH => Self::Binary(BinaryNodeFact::deserialize(data)?),
             EdgeNodeFact::PREIMAGE_LENGTH => Self::Edge(EdgeNodeFact::deserialize(data)?),
             other => {
@@ -280,7 +232,6 @@ where
 {
     fn hash(&self) -> Hash {
         match self {
-            Self::Empty(empty) => <EmptyNodeFact as Fact<S, H>>::hash(empty),
             Self::Binary(binary) => <BinaryNodeFact as Fact<S, H>>::hash(binary),
             Self::Edge(edge) => <EdgeNodeFact as Fact<S, H>>::hash(edge),
         }
@@ -296,7 +247,6 @@ where
 {
     fn to_tuple(&self) -> Vec<BigUint> {
         match self {
-            Self::Empty(empty) => <EmptyNodeFact as InnerNodeFact<S, H>>::to_tuple(empty),
             Self::Binary(binary) => <BinaryNodeFact as InnerNodeFact<S, H>>::to_tuple(binary),
             Self::Edge(edge) => <EdgeNodeFact as InnerNodeFact<S, H>>::to_tuple(edge),
         }

crates/starknet-os/src/starkware_utils/commitment_tree/patricia_tree/virtual_patricia_node.rs

@@ -248,7 +248,6 @@ where
                     Self::from_hash(binary_node_fact.left_node, children_height),
                     Self::from_hash(binary_node_fact.right_node, children_height),
                 )),
-                PatriciaNodeFact::Empty(_) => Err(TreeError::IsEmpty),
             }
         }
         .boxed()

crates/starknet-os/src/starkware_utils/serializable.rs

@@ -69,16 +69,6 @@ mod tests {
 
     impl SerializationPrefix for MySerializable {}
 
-    impl Serializable for MySerializable {
-        fn serialize(&self) -> Result<Vec<u8>, SerializeError> {
-            panic!("Not implemented, on purpose");
-        }
-
-        fn deserialize(_data: &[u8]) -> Result<Self, DeserializeError> {
-            panic!("Not implemented, on purpose");
-        }
-    }
-
     #[test]
     fn test_class_name_prefix() {
         assert_eq!(MySerializable::class_name_prefix(), "my_serializable".as_bytes());