Remove unused code from starkware_utils #440
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whichqua
reviewed
Nov 27, 2024
| @@ -174,20 +174,7 @@ where | |||
| ffc: &'a mut FactFetchingContext<S, H>, | |||
| indices: &'a [TreeIndex], | |||
| facts: &'a mut Option<BinaryFactDict>, | |||
| ) -> impl std::future::Future<Output = Result<HashMap<TreeIndex, LF>, TreeError>> + Send { | |||
There was a problem hiding this comment.
Any reason why you have removed this default implementation?
There was a problem hiding this comment.
No particular reason except it's never used. This trait is only implemented in virtual_patricia_node.rs, and it has it's own implementation of _get_leaves.
whichqua
reviewed
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: N/A
Type
Description
Removed several unused methods and unreachable code from
starkware_utils.Breaking changes?