[feat] OP_[2..16] and OP_MIN implementation
#33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptisserand
force-pushed
the
feat/17-implement-OP_MIN-opcode
branch
from
7d1b350
to
8262f67
Compare
j1mbo64
reviewed
Jul 27, 2024
There was a problem hiding this comment.
OP_2 to OP_16 already merged in #32, but your tests are shorter.
@b-j-roberts maybe we can use his tests ?
j1mbo64
approved these changes
Jul 27, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing purpose of
OP_MINopcode, I have added implementation & test for OP_2 to OP_16To reduce code duplication in tests, I have wrote the following function
fn test_op_n(value: u8)intest_opcodes.cairo