[feat] OP_[2..16] and OP_MIN implementation (#33)

* feat: #5 add `OP_[2..16]` opcodes * feat: #17 add `OP_MIN` opcode --------- Co-authored-by: Brandon Roberts <[email protected]>
keep-starknet-strange · Jul 29, 2024 · 256c2da · 256c2da
1 parent 66bbffd
commit 256c2da
Show file tree

Hide file tree

Showing 3 changed files with 68 additions and 219 deletions.
diff --git a/src/compiler.cairo b/src/compiler.cairo
@@ -45,6 +45,7 @@ pub impl CompilerTraitImpl of CompilerTrait {
         opcodes.insert('OP_NOT', Opcode::OP_NOT);
         opcodes.insert('OP_ADD', Opcode::OP_ADD);
         opcodes.insert('OP_SUB', Opcode::OP_SUB);
+        opcodes.insert('OP_MIN', Opcode::OP_MIN);
         opcodes.insert('OP_MAX', Opcode::OP_MAX);
         Compiler { opcodes }
     }

diff --git a/src/opcodes/opcodes.cairo b/src/opcodes/opcodes.cairo
@@ -26,6 +26,7 @@ pub mod Opcode {
     pub const OP_NOT: u8 = 145;
     pub const OP_ADD: u8 = 147;
     pub const OP_SUB: u8 = 148;
+    pub const OP_MIN: u8 = 163;
     pub const OP_MAX: u8 = 164;
 
     use shinigami::engine::{Engine, EngineTrait};
@@ -196,7 +197,7 @@ pub mod Opcode {
             160 => not_implemented(ref engine),
             161 => not_implemented(ref engine),
             162 => not_implemented(ref engine),
-            163 => not_implemented(ref engine),
+            163 => opcode_min(ref engine),
             164 => opcode_max(ref engine),
             _ => not_implemented(ref engine)
         }
@@ -297,6 +298,17 @@ pub mod Opcode {
         }
     }
 
+    fn opcode_min(ref engine: Engine) {
+        let a = engine.dstack.pop_int();
+        let b = engine.dstack.pop_int();
+
+        engine.dstack.push_int(if a < b {
+            a
+        } else {
+            b
+        });
+    }
+
     fn not_implemented(ref engine: Engine) {
         panic!("Opcode not implemented");
     }