Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the deployment templates to comply with the slack bot changes #766

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update the deployment templates to comply with the slack bot changes #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion chart/keel/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ The following table lists has the main configurable parameters (polling, trigger
| `webhook.endpoint` | Remote webhook endpoint | |
| `slack.enabled` | Enable/disable Slack Notification | `false` |
| `slack.botName` | Name of the Slack bot | |
| `slack.token` | Slack token | |
| `slack.botToken` | Slack bot token | |
| `slack.appToken` | Slack application level token | |
| `slack.channel` | Slack channel | |
| `slack.approvalsChannel` | Slack channel for approvals | |
| `teams.enabled` | Enable/disable MS Teams Notification | `false` |
Expand Down
3 changes: 2 additions & 1 deletion chart/keel/templates/secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ data:
AWS_SECRET_ACCESS_KEY: {{ .Values.ecr.secretAccessKey | b64enc }}
{{- end }}
{{- if .Values.slack.enabled }}
SLACK_TOKEN: {{ .Values.slack.token | b64enc }}
SLACK_BOT_TOKEN: {{ .Values.slack.botToken | b64enc }}
SLACK_APP_TOKEN: {{ .Values.slack.appToken | b64enc }}
{{- end }}
{{- if .Values.googleApplicationCredentials }}
google-application-credentials.json: {{ .Values.googleApplicationCredentials }}
Expand Down
3 changes: 2 additions & 1 deletion chart/keel/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ webhook:
slack:
enabled: false
botName: ""
token: ""
appToken: ""
botToken: ""
channel: ""
approvalsChannel: ""

Expand Down
6 changes: 4 additions & 2 deletions deployment/deployment-template.yaml
View file
Open in desktop
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file generated somehow ?

Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,10 @@ spec:
# Enable MS Teams webhook endpoint
- name: TEAMS_WEBHOOK_URL
value: "{{ .teams_webhook_url }}"
- name: SLACK_TOKEN
value: "{{ .slack_token }}"
- name: SLACK_APP_TOKEN
value: "{{ .slack_app_token }}"
- name: SLACK_BOT_TOKEN
value: "{{ .slack_bot_token }}"
- name: SLACK_CHANNELS
value: "{{ .slack_channel | default "general" }}"
- name: SLACK_APPROVALS_CHANNEL
Expand Down